Issue 345002: In ~BrowserToolbarGtk, remove notifications we added in the ctor....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 345002: In ~BrowserToolbarGtk, remove notifications we added in the ctor.... (Closed)

Created:
11 years, 1 month ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

In ~BrowserToolbarGtk, remove notifications we added in the ctor. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30302

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/gtk/browser_toolbar_gtk.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

Trying to track down a ObserverList bug. Turned on some DCHECKs and flushed out cases ...

11 years, 1 month ago (2009-10-27 21:48:51 UTC) #1

Elliot Glaysher

11 years, 1 month ago (2009-10-28 15:44:09 UTC) #2

LGTM

On Tue, Oct 27, 2009 at 2:48 PM,  <thestig@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Message:
> Trying to track down a ObserverList bug. Turned on some DCHECKs and flush=
ed
> out
> cases where the number of notification adds / removes aren't balanced.
>
> Description:
> In ~BrowserToolbarGtk, remove notifications we added in the ctor.
>
> BUG=3Dnone
> TEST=3Dnone
>
> Please review this at http://codereview.chromium.org/345002
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 chrome/browser/gtk/browser_toolbar_gtk.cc
>
>
> Index: chrome/browser/gtk/browser_toolbar_gtk.cc
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- chrome/browser/gtk/browser_toolbar_gtk.cc =A0 (revision 30237)
> +++ chrome/browser/gtk/browser_toolbar_gtk.cc =A0 (working copy)
> @@ -93,6 +93,12 @@
> =A0}
>
> =A0BrowserToolbarGtk::~BrowserToolbarGtk() {
> + =A0browser_->command_updater()->RemoveCommandObserver(IDC_BACK, this);
> + =A0browser_->command_updater()->RemoveCommandObserver(IDC_FORWARD, this=
);
> + =A0browser_->command_updater()->RemoveCommandObserver(IDC_RELOAD, this)=
;
> + =A0browser_->command_updater()->RemoveCommandObserver(IDC_HOME, this);
> + =A0browser_->command_updater()->RemoveCommandObserver(IDC_BOOKMARK_PAGE=
,
> this);
> +
> =A0 offscreen_entry_.Destroy();
>
> =A0 // When we created our MenuGtk objects, we pass them a pointer to our
> accel
>
>
>

Expand Messages | Collapse Messages