Issue 3450016: Remove default BIOS flashrom memory layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3450016: Remove default BIOS flashrom memory layout (Closed)

Created:
10 years, 3 months ago by Hung-Te

Modified:
9 years, 7 months ago

Reviewers:
Randall Spangler, Louis

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/autotest.git

Visibility:
Public.

Description

Remove default BIOS flashrom memory layout The memory layout of new BIOS firmware seem to change often in the future. To prevent confusion, the default layout description for BIOS should be removed. BUG=none TEST=none Change-Id: Ib273e761bbd5bc25f2daa22b421de26f421cbcd0 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=5605b14

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -16 lines)			Patch
	M	client/common_lib/flashrom_util.py	View		2 chunks	+5 lines, -16 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Louis

It seems this could affect firmware test. See line 82 in platform/firmware/saft/flashrom_handler.py: self.bios_layout = self.fum.detect_chromeos_layout('bios', ...

10 years, 3 months ago (2010-09-21 06:14:14 UTC) #2

Hung-Te

On 2010/09/21 06:14:14, Louis wrote: > It seems this could affect firmware test. See line ...

10 years, 3 months ago (2010-09-21 06:22:05 UTC) #3

Louis

okay. false alarm. saft has its own flashrom_util.py. my code is too old. LGTM now.

10 years, 3 months ago (2010-09-21 06:22:07 UTC) #4

LGTM

Expand Messages | Collapse Messages