Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: client/common_lib/flashrom_util.py

Issue 3450016: Remove default BIOS flashrom memory layout (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/autotest.git
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/common_lib/flashrom_util.py
diff --git a/client/common_lib/flashrom_util.py b/client/common_lib/flashrom_util.py
index 2986c68305758b46e9d135ee1d94c83bb0a8479c..8d0d54519e8e9d899d4bb7585b4736a1b009de2e 100644
--- a/client/common_lib/flashrom_util.py
+++ b/client/common_lib/flashrom_util.py
@@ -43,23 +43,11 @@ DEFAULT_TARGET_NAME_EC = 'ec'
# The default description of ChromeOS firmware layout
# Check help(compile_layout) for the syntax.
-# NOTE: "FVMAIN" is not typo, although it seems like lack of 'A' as postfix.
+# NOTE: Since the memory layout of BIOS may change very often,
+# the default layout is removed to prevent confusion.
+# Any BIOS image without FMAP is considered as corrupted.
DEFAULT_CHROMEOS_FIRMWARE_LAYOUT_DESCRIPTIONS = {
- "bios": """
- FV_LOG = 0x20000,
- NV_COMMON_STORE = 0x10000,
- VBOOTA = 0x02000,
- FVMAIN = 0xB0000,
- VBOOTB = 0x02000,
- FVMAINB = 0xB0000,
- NVSTORAGE = 0x10000,
- FV_RW_RESERVED = *,
- |
- FV_RO_RESERVED = *,
- FVDEV = 0xB0000,
- FV_GBB = 0x20000,
- FV_BSTUB = 0x40000,
- """,
+ "bios": "", # retrieve from fmap, no defaults.
"ec": """
EC_RO
|
@@ -68,6 +56,7 @@ DEFAULT_CHROMEOS_FIRMWARE_LAYOUT_DESCRIPTIONS = {
}
# The default conversion table for fmap_decode.
+# NOTE: "FVMAIN" is not typo, although it seems like lack of 'A' as postfix.
DEFAULT_CHROMEOS_FMAP_CONVERSION = {
"Boot Stub": "FV_BSTUB",
"GBB Area": "FV_GBB",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698