Issue 3448022: build_image: Merge x86 and ARM where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3448022: build_image: Merge x86 and ARM where possible. (Closed)

Created:
10 years, 3 months ago by Kenneth Waters

Modified:
9 years, 7 months ago

Reviewers:
Will Drewry

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git

Visibility:
Public.

Description

build_image: Merge x86 and ARM where possible. - I looked at all of the x86 and ARM paths through out build image scripts, these changes clean up stale comments, stale code, and unforks some small things. BUG=none TEST=Built images for x86-generic, arm-generic and tegra2-seaboard, booted tegra2-seaboard image. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e3049de

Patch Set 1 #

Patch Set 2 : Codereview ate my homework. #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -47 lines)			Patch
M	bin/cros_make_image_bootable	View	3 chunks	+3 lines, -16 lines	0 comments	Download
M	build_gpt.sh	View	3 chunks	+1 line, -16 lines	0 comments	Download
M	build_image	View	4 chunks	+1 line, -6 lines	0 comments	Download
M	create_esp.sh	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	image_to_usb.sh	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	update_bootloaders.sh	View	3 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Will Drewry

10 years, 2 months ago (2010-09-30 01:13:05 UTC) #2

LGTM pending some TEST=comments :) Did an x86 and arm build_image work?

Kill moar code!

Expand Messages | Collapse Messages