create_esp.sh - Issue 3448022: build_image: Merge x86 and ARM where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: create_esp.sh

Issue 3448022: build_image: Merge x86 and ARM where possible. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crosutils.git

Patch Set: Codereview ate my homework. Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: create_esp.sh

diff --git a/create_esp.sh b/create_esp.sh

index 5b345e20e1c6e632394fd6d484fb90e6c23caa94..261b8de340e3eee003eaf3fa44eb8a2009893c52 100755

--- a/create_esp.sh

+++ b/create_esp.sh

@@ -26,8 +26,7 @@ fi

info "Creating a new esp image at ${FLAGS_to}" anyway.

# Create EFI System Partition to boot stock EFI BIOS (but not ChromeOS EFI

-# BIOS). We only need this for x86, but it's simpler and safer to keep the

-# disk images the same for both x86 and ARM.

+# BIOS). ARM uses this space to determine which partition is bootable.

# NOTE: The size argument for mkfs.vfat is in 1024-byte blocks.

# We'll hard-code it to 16M for now.

ESP_BLOCKS=16384

« no previous file with comments | « build_image ('k') | image_to_usb.sh » ('j') | no next file with comments »