Adding x64 configurations for windows....

Adding x64 configurations for windows.
These do not build, but are for experimentation.

BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30683

[bradn, 2009-10-30 21:58:32]

Please add anybody else who you can think of that might care about how windows
x64 looks.

[M-A Ruel, 2009-10-30 22:32:14]

lgtm

On Oct 30, 2009 5:58 PM, <bradnelson@google.com> wrote:

Reviewers: Marc-Antoine Ruel, ilewis, gregoryd, darin,

Message:
Please add anybody else who you can think of that might care about how
windows
x64 looks.

Description:
Adding x64 configurations for windows.
These do not build, but are for experimentation.

BUG=None
TEST=None


Please review this at http://codereview.chromium.org/344041

SVN Base: svn://chrome-svn.corp.google.com/chrome/trunk/src/

Affected files:
 M     DEPS
 M     build/common.gypi


Index: DEPS
===================================================================
--- DEPS        (revision 30636)
+++ DEPS        (working copy)
@@ -37,7 +37,7 @@
    "http://pywebsocket.googlecode.com/svn/trunk/src@86",

  "src/tools/gyp":
-    "http://gyp.googlecode.com/svn/trunk@738",
+    "http://gyp.googlecode.com/svn/trunk@739",

  "src/v8":
    "http://v8.googlecode.com/svn/trunk@3177",
Index: build/common.gypi
===================================================================
--- build/common.gypi   (revision 30557)
+++ build/common.gypi   (working copy)
@@ -357,11 +357,7 @@
          'IntermediateDirectory': '$(OutDir)\\obj\\$(ProjectName)',
          'CharacterSet': '1',
        },
-        'conditions': [
-          ['OS=="win"', {
-            'configuration_platform': 'Win32',
-          }],
-        ],
+        'msvs_configuration_platform': 'Win32',
      },
      'Debug': {
        'inherit_from': ['Common'],
@@ -446,6 +442,22 @@
            'inherit_from': ['Release'],
            'defines': ['NO_TCMALLOC'],
          },
+          'Debug_x64': {
+            'inherit_from': ['Debug'],
+            'msvs_configuration_platform': 'x64',
+          },
+          'Release_x64': {
+            'inherit_from': ['Release'],
+            'msvs_configuration_platform': 'x64',
+          },
+          'Purify': {
+            'inherit_from': ['Purify'],
+            'msvs_configuration_platform': 'x64',
+          },
+          'Release - no tcmalloc_x64': {
+            'inherit_from': ['Release - no tcmalloc'],
+            'msvs_configuration_platform': 'x64',
+          },
        }],
      ],
    },

[TVL, 2009-11-01 21:30:18]

http://codereview.chromium.org/344041/diff/3001/3002
File build/common.gypi (right):

http://codereview.chromium.org/344041/diff/3001/3002#newcode454
Line 454: 'inherit_from': ['Purify'],
drive by: Purify inherits from Purify?  should this be Purify_x64 from Purify?

[bradn, 2009-11-01 22:28:10]

Thanks, good catch! Hadn't tested that one directly.
Really should add a better parser to gyp, so it can catch duplicate dict
entries.
For that matter it really should complain in python....
-BradN

On Sun, Nov 1, 2009 at 1:30 PM, <thomasvl@chromium.org> wrote:

>
> http://codereview.chromium.org/344041/diff/3001/3002
> File build/common.gypi (right):
>
> http://codereview.chromium.org/344041/diff/3001/3002#newcode454
> Line 454: 'inherit_from': ['Purify'],
> drive by: Purify inherits from Purify?  should this be Purify_x64 from
> Purify?
>
> http://codereview.chromium.org/344041
>