Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 344014: Standardize on the plugin icon (puzzle piece) as the default icon for... (Closed)

Created:
11 years, 1 month ago by Finnur
Modified:
9 years, 6 months ago
Reviewers:
Aaron Boodman, rafaelw
CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Standardize on the plugin icon (puzzle piece) as the default icon for install dialogs and the management ui page. Also changed the margins on the body to match the download page and the history page so it doesn't look as bad when you switch between them. TEST=Install an extension without an icon and you should see the puzzle piece icon in the install dialog. TEST=Open the chrome://extensions page and you should see the same icon in the top left corner. BUG=25906

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -61 lines) Patch
A chrome/app/theme/extensions_section.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 2 chunks +2 lines, -1 line 0 comments Download
D chrome/browser/resources/default_extension_icon_128.png View 1 chunk +0 lines, -50 lines 0 comments Download
M chrome/browser/resources/extensions_ui.html View 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/views/extensions/extension_install_prompt.cc View 1 chunk +5 lines, -1 line 1 comment Download

Messages

Total messages: 6 (0 generated)
Finnur
11 years, 1 month ago (2009-10-28 17:28:13 UTC) #1
rafaelw
lgtm http://codereview.chromium.org/344014/diff/1/6 File chrome/browser/views/extensions/extension_install_prompt.cc (right): http://codereview.chromium.org/344014/diff/1/6#newcode39 Line 39: // Scale down to 85x85, but allow ...
11 years, 1 month ago (2009-10-28 19:21:32 UTC) #2
Aaron Boodman
Can we see screen caps please?
11 years, 1 month ago (2009-10-28 19:23:44 UTC) #3
Finnur
Uploaded to the bug. On Wed, Oct 28, 2009 at 12:23, <aa@chromium.org> wrote: > Can ...
11 years, 1 month ago (2009-10-28 20:17:33 UTC) #4
Aaron Boodman
lgtm
11 years, 1 month ago (2009-10-28 20:39:15 UTC) #5
Finnur
11 years, 1 month ago (2009-10-28 20:43:03 UTC) #6
Rafael,

Filed http://crbug.com/26123 and http://crbug.com/26124.

And checked in.

On 2009/10/28 20:39:15, Aaron Boodman wrote:
> lgtm

Powered by Google App Engine
This is Rietveld 408576698