Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 344009: Setting the SVN eol style to LF on chrome frame sources (Closed)

Created:
11 years, 1 month ago by ananta
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, amit, darin (slow to review), Paweł Hajdan Jr.
Visibility:
Public.

Description

Setting the SVN eol style to LF on chrome frame sources Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30332

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -30 lines) Patch
M chrome_frame/chrome_frame_histograms.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/chrome_frame_histograms.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/chrome_frame_npapi_entrypoints.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/chrome_frame_unittest_main.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
MM chrome_frame/chrome_launcher_main.cc View 1 2 3 1 chunk +79 lines, -79 lines 0 comments Download
M chrome_frame/chrome_protocol.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/chrome_protocol.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/com_message_event.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/com_message_event.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/com_type_info_holder.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/extra_system_apis.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/ff_30_privilege_check.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/ff_privilege_check.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/find_dialog.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/function_stub.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/icu_stubs.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/ie8_types.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/iids.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/in_place_menu.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/np_browser_functions.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/np_browser_functions.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/np_event_listener.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/np_event_listener.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/np_proxy_service.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/np_proxy_service.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/npapi_url_request.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/npapi_url_request.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/ns_associate_iid_win.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/ns_isupports_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/ole_document_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/precompiled.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/precompiled.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/resource.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/scoped_ns_ptr_win.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/script_security_manager.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/sync_msg_reply_dispatcher.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/sync_msg_reply_dispatcher.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/test/net/dialog_watchdog.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/test/net/dialog_watchdog.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/test/net/process_singleton_subclass.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/test/net/process_singleton_subclass.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/test/net/test_automation_provider.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/test/net/test_automation_provider.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/test/net/test_automation_resource_message_filter.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/test/net/test_automation_resource_message_filter.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/unittest_precompile.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/unittest_precompile.cc View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/urlmon_upload_data_stream.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/urlmon_upload_data_stream.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome_frame/urlmon_upload_data_stream_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ananta
11 years, 1 month ago (2009-10-28 05:04:00 UTC) #1
tommi (sloooow) - chröme
http://codereview.chromium.org/344009/diff/1/2 File chrome_frame/utils.h (right): http://codereview.chromium.org/344009/diff/1/2#newcode13 Line 13: #include "chrome_frame/utils.h" did you mean to add this?
11 years, 1 month ago (2009-10-28 05:08:08 UTC) #2
tommi (sloooow) - chröme
11 years, 1 month ago (2009-10-28 22:05:04 UTC) #3 
lgtm with the added #include removed

On Wed, Oct 28, 2009 at 1:08 AM, <tommi@chromium.org> wrote:

>
> http://codereview.chromium.org/344009/diff/1/2
> File chrome_frame/utils.h (right):
>
> http://codereview.chromium.org/344009/diff/1/2#newcode13
> Line 13: #include "chrome_frame/utils.h"
> did you mean to add this?
>
>
> http://codereview.chromium.org/344009
>

Powered by Google App Engine
This is Rietveld 408576698