Replace newline characters in factory tests

Replace newline characters with "<br/>" in factory tests when raising test error exceptions, and replace them back to "\n" in factory_Review.

This patch should make the status file easier to parse.

BUG=chrome-os-partner:1080
TEST=manual

Change-Id: Ide8389dcbf302af15ccea73b08a5f16dab01dd73

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e29978a

[Hung-Te, 2010-09-16 04:14:59]

What about hooking the error.TestError/TestFail?
The newline is helpful when reading log on console

[clchiou, 2010-09-17 02:13:51]

Thanks for the comments, Hung-Te.
I forgot to reply you that I had rewrote based on your comments.
Please take a look.

On 2010/09/16 04:14:59, Hung-Te wrote:
> What about hooking the error.TestError/TestFail?
> The newline is helpful when reading log on console

[Hung-Te, 2010-09-17 11:37:37]

http://codereview.chromium.org/3438007/diff/3001/4001
File client/bin/factory_error.py (right):

http://codereview.chromium.org/3438007/diff/3001/4001#newcode1
client/bin/factory_error.py:1: from autotest_lib.client.common_lib import error
Please add the copy right holder and a short comment/description for what is
this file and how to use it

http://codereview.chromium.org/3438007/diff/3001/4001#newcode11
client/bin/factory_error.py:11: exec _template % {'name':_name}
what about using meta classes here?
http://docs.python.org/library/functions.html#type

def _mystr_(self):
 return super(type(self), self).__str__(self).replace...

__dict__[_name] = type(_name, (_thing,),dict(__str__=mystr))

[clchiou, 2010-09-20 04:00:52]

Hi Hung-Te,

Thanks for the comments.  I've addressed them all.  Please take a look when you
have time.

http://codereview.chromium.org/3438007/diff/3001/4001
File client/bin/factory_error.py (right):

http://codereview.chromium.org/3438007/diff/3001/4001#newcode1
client/bin/factory_error.py:1: from autotest_lib.client.common_lib import error
On 2010/09/17 11:37:37, Hung-Te wrote:
> Please add the copy right holder and a short comment/description for what is
> this file and how to use it

Done.

http://codereview.chromium.org/3438007/diff/3001/4001#newcode11
client/bin/factory_error.py:11: exec _template % {'name':_name}
On 2010/09/17 11:37:37, Hung-Te wrote:
> what about using meta classes here?
> http://docs.python.org/library/functions.html#type
> 
> def _mystr_(self):
>  return super(type(self), self).__str__(self).replace...
> 
> __dict__[_name] = type(_name, (_thing,),dict(__str__=mystr))

Done.

[Hung-Te, 2010-09-20 07:02:54]

http://codereview.chromium.org/3438007/diff/9001/10001
File client/bin/factory_error.py (right):

http://codereview.chromium.org/3438007/diff/9001/10001#newcode12
client/bin/factory_error.py:12: globals().update( \
You don't need back-quote when you have open parentheses in python.

http://codereview.chromium.org/3438007/diff/9001/10001#newcode13
client/bin/factory_error.py:13: (name, type(name, (thing,),
The indent seems not appropriate here, and the code itself seems a little lack
of readability.

I think you can wrap these stuff into a function with local variables and that
would make the source more readable.

Check
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html#List_Comprehen...

Note: if the difference between __all__ and __dict__ is not really important, we
can use for name, thing in error.__dict__.items() to replace zip and map.

[clchiou, 2010-09-20 10:25:20]

Hi Hung-Te,

Thanks for the timely response.  I've addressed your comments.  Please take a
look when you have time.

http://codereview.chromium.org/3438007/diff/9001/10001
File client/bin/factory_error.py (right):

http://codereview.chromium.org/3438007/diff/9001/10001#newcode13
client/bin/factory_error.py:13: (name, type(name, (thing,),
On 2010/09/20 07:02:55, Hung-Te wrote:
> The indent seems not appropriate here, and the code itself seems a little lack
> of readability.
> 
> I think you can wrap these stuff into a function with local variables and that
> would make the source more readable.
> 
> Check
>
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html#List_Comprehen...
> 
> Note: if the difference between __all__ and __dict__ is not really important,
we
> can use for name, thing in error.__dict__.items() to replace zip and map.

Remove list comprehension.

[Hung-Te, 2010-09-21 02:38:36]

LGTM with one more suggestion for coding style

http://codereview.chromium.org/3438007/diff/2002/14002
File client/bin/factory_error.py (right):

http://codereview.chromium.org/3438007/diff/2002/14002#newcode16
client/bin/factory_error.py:16: _glob[_name] = type(_name, (_thing,),
dict(__str__=
I think the proper coding style is to not break an a=b.

_new_str = lambda ...
_glob[_name] .... __str__=_new_str)...

[clchiou, 2010-09-21 12:27:24]

Submit.  Thanks for the comments.

http://codereview.chromium.org/3438007/diff/2002/14002
File client/bin/factory_error.py (right):

http://codereview.chromium.org/3438007/diff/2002/14002#newcode16
client/bin/factory_error.py:16: _glob[_name] = type(_name, (_thing,),
dict(__str__=
On 2010/09/21 02:38:37, Hung-Te wrote:
> I think the proper coding style is to not break an a=b.
> 
> _new_str = lambda ...
> _glob[_name] .... __str__=_new_str)...

Done.