Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: client/site_tests/factory_Review/factory_Review.py

Issue 3438007: Replace newline characters in factory tests (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/autotest.git
Patch Set: Address review comments Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: client/site_tests/factory_Review/factory_Review.py
diff --git a/client/site_tests/factory_Review/factory_Review.py b/client/site_tests/factory_Review/factory_Review.py
index 29f10480e6ca7c183e8c6aae000c50728f541fb4..1b2b647fbe2483c622be2a4965099e64219d434c 100644
--- a/client/site_tests/factory_Review/factory_Review.py
+++ b/client/site_tests/factory_Review/factory_Review.py
@@ -23,7 +23,6 @@ from itertools import count, izip, product
from autotest_lib.client.bin import factory
from autotest_lib.client.bin import factory_ui_lib as ful
from autotest_lib.client.bin import test
-from autotest_lib.client.common_lib import error
from factory import AutomatedSequence
@@ -81,8 +80,10 @@ class factory_Review(test.test):
return vbox
def make_error_tab(self, status_map, t):
- msg = '%s (%s)\n%s' % (t.label_en, t.label_zw,
- status_map.lookup_error_msg(t))
+ msg = status_map.lookup_error_msg(t)
+ if isinstance(msg, str) or isinstance(msg, str):
+ msg = msg.replace('<br/>', '\n')
+ msg = '%s (%s)\n%s' % (t.label_en, t.label_zw, msg)
label = ful.make_label(msg,
font=LABEL_EN_FONT,
alignment=(0.0, 0.0))

Powered by Google App Engine
This is Rietveld 408576698