Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: user_collector.cc

Issue 3436029: crash-reporter: Send OS version at time of crash and related improvements (Closed) Base URL: http://git.chromium.org/git/crash-reporter.git
Patch Set: respond to petkov review Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « kernel_collector_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: user_collector.cc
diff --git a/user_collector.cc b/user_collector.cc
index e051a4ac342f301ca37d5a138a5285a81332ac51..18ab7b95dd509dc85e31decec3edcdaf16bde42d 100644
--- a/user_collector.cc
+++ b/user_collector.cc
@@ -275,6 +275,11 @@ bool UserCollector::GenerateDiagnostics(pid_t pid,
conversion_result = false;
}
+ WriteCrashMetaData(
+ crash_path.Append(
+ StringPrintf("%s.meta", dump_basename.c_str())),
+ exec_name);
+
if (conversion_result) {
logger_->LogInfo("Stored minidump to %s", minidump_path.value().c_str());
}
@@ -298,10 +303,12 @@ bool UserCollector::HandleCrash(int signal, int pid, const char *force_exec) {
// failing by indicating an unknown name.
exec = "unknown";
}
- logger_->LogWarning("Received crash notification for %s[%d] sig %d",
- exec.c_str(), pid, signal);
+ bool feedback = is_feedback_allowed_function_();
+ logger_->LogWarning("Received crash notification for %s[%d] sig %d (%s)",
+ exec.c_str(), pid, signal,
+ feedback ? "handling" : "ignoring");
- if (is_feedback_allowed_function_()) {
+ if (feedback) {
count_crash_function_();
if (generate_diagnostics_) {
« no previous file with comments | « kernel_collector_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698