crash-reporter: Send OS version at time of crash and related improvements

user_collector.cc

 // Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "crash-reporter/user_collector.h"
 
 #include <grp.h>  // For struct group.
 #include <pwd.h>  // For struct passwd.
 #include <sys/types.h>  // For getpwuid_r and getgrnam_r.
 
@@ skipping 257 matching lines @@
 
   bool conversion_result = true;
   if (!ConvertCoreToMinidump(core_path,
                              container_dir,  // procfs directory
                              minidump_path,
                              container_dir)) {  // temporary directory
     // Note we leave the container directory for inspection.
     conversion_result = false;
   }
 
+  WriteCrashMetaData(
+      crash_path.Append(
+          StringPrintf("%s.meta", dump_basename.c_str())),
+      exec_name);
+
   if (conversion_result) {
     logger_->LogInfo("Stored minidump to %s", minidump_path.value().c_str());
   }
 
   if (!file_util::PathExists(FilePath(kLeaveCoreFile))) {
     file_util::Delete(core_path, false);
   } else {
     logger_->LogInfo("Leaving core file at %s", core_path.value().c_str());
   }
 
   return conversion_result;
 }
 
 bool UserCollector::HandleCrash(int signal, int pid, const char *force_exec) {
   CHECK(initialized_);
   std::string exec;
   if (force_exec) {
     exec.assign(force_exec);
   } else if (!GetExecutableBaseNameFromPid(pid, &exec)) {
     // If for some reason we don't have the base name, avoid completely
     // failing by indicating an unknown name.
     exec = "unknown";
   }
-  logger_->LogWarning("Received crash notification for %s[%d] sig %d",
-                      exec.c_str(), pid, signal);
+  bool feedback = is_feedback_allowed_function_();
+  logger_->LogWarning("Received crash notification for %s[%d] sig %d (%s)",
+                      exec.c_str(), pid, signal,
+                      feedback ? "handling" : "ignoring");
 
-  if (is_feedback_allowed_function_()) {
+  if (feedback) {
     count_crash_function_();
 
     if (generate_diagnostics_) {
       return GenerateDiagnostics(pid, exec);
     }
   }
   return true;
 }