Issue 3431032: Change ChildProcessSecurityPolicy to store a list of allowed flags for...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3431032: Change ChildProcessSecurityPolicy to store a list of allowed flags for... (Closed)

Created:
10 years, 2 months ago by dumi

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), abarth-chromium

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr., jam, darin-cc_chromium.org, brettw-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Change ChildProcessSecurityPolicy to store a list of allowed flags for each file. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60742

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 3

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -37 lines)			Patch
M	chrome/browser/child_process_security_policy.h	View		2 chunks	+14 lines, -2 lines	1 comment	Download
M	chrome/browser/child_process_security_policy.cc	View	1	8 chunks	+40 lines, -15 lines	2 comments	Download
M	chrome/browser/child_process_security_policy_unittest.cc	View	1	4 chunks	+79 lines, -10 lines	0 comments	Download
M	chrome/browser/plugin_process_host.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/blob_dispatcher_host.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/redirect_to_file_resource_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/resource_dispatcher_host.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/resource_message_filter.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

10 years, 2 months ago (2010-09-28 06:18:27 UTC) #3

just some minor nits, otherwise LGTM

http://codereview.chromium.org/3431032/diff/11001/12001
File chrome/browser/child_process_security_policy.cc (right):

http://codereview.chromium.org/3431032/diff/11001/12001#newcode17
chrome/browser/child_process_security_policy.cc:17: const int
kReadFilePermissions =
nit: mark this as 'static'

http://codereview.chromium.org/3431032/diff/11001/12001#newcode100
chrome/browser/child_process_security_policy.cc:100: typedef std::map<FilePath,
int> FileMap; // bit-set of PlatformFileFlags
nit: two spaces before the '//'

http://codereview.chromium.org/3431032/diff/11001/12002
File chrome/browser/child_process_security_policy.h (right):

http://codereview.chromium.org/3431032/diff/11001/12002#newcode111
chrome/browser/child_process_security_policy.h:111: // Determins if certain
permissions were granted for a file. |permissions|
nit: Determins -> Determines

Expand Messages | Collapse Messages