Change ChildProcessSecurityPolicy to store a list of allowed flags for...

chrome/browser/renderer_host/resource_message_filter.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/resource_message_filter.h"
 
 #include "app/clipboard/clipboard.h"
 #include "base/callback.h"
 #include "base/command_line.h"
 #if defined(OS_POSIX)
@@ skipping 1431 matching lines @@
     net::HttpNetworkLayer::EnableSpdy("npn,force-alt-protocols");
   } else {
     net::HttpNetworkLayer::EnableSpdy("npn-http");
   }
 }
 
 void ResourceMessageFilter::OnGetFileSize(const FilePath& path,
                                           IPC::Message* reply_msg) {
   // Get file size only when the child process has been granted permission to
   // upload the file.
-  if (!ChildProcessSecurityPolicy::GetInstance()->CanUploadFile(id(), path)) {
+  if (!ChildProcessSecurityPolicy::GetInstance()->CanReadFile(id(), path)) {
     ViewHostMsg_GetFileSize::WriteReplyParams(
         reply_msg, static_cast<int64>(-1));
     Send(reply_msg);
     return;
   }
 
   // Getting file size could take long time if it lives on a network share,
   // so run it on FILE thread.
   ChromeThread::PostTask(
       ChromeThread::FILE, FROM_HERE,
       NewRunnableMethod(
           this, &ResourceMessageFilter::OnGetFileInfoOnFileThread, path,
           reply_msg, &WriteFileSize));
 }
 
 void ResourceMessageFilter::OnGetFileModificationTime(const FilePath& path,
                                                       IPC::Message* reply_msg) {
   // Get file modification time only when the child process has been granted
   // permission to upload the file.
-  if (!ChildProcessSecurityPolicy::GetInstance()->CanUploadFile(id(), path)) {
+  if (!ChildProcessSecurityPolicy::GetInstance()->CanReadFile(id(), path)) {
     ViewHostMsg_GetFileModificationTime::WriteReplyParams(reply_msg,
                                                           base::Time());
     Send(reply_msg);
     return;
   }
 
   // Getting file modification time could take a long time if it lives on a
   // network share, so run it on the FILE thread.
   ChromeThread::PostTask(
       ChromeThread::FILE, FROM_HERE,
@@ skipping 18 matching lines @@
       ChromeThread::IO, FROM_HERE,
       NewRunnableMethod(this, &ResourceMessageFilter::Send, reply_msg));
 }
 
 void ResourceMessageFilter::OnOpenFile(const FilePath& path,
                                        int mode,
                                        IPC::Message* reply_msg) {
   // Open the file only when the child process has been granted permission to
   // upload the file.
   // TODO(jianli): Do we need separate permission to control opening the file?
-  if (!ChildProcessSecurityPolicy::GetInstance()->CanUploadFile(id(), path)) {
+  if (!ChildProcessSecurityPolicy::GetInstance()->CanReadFile(id(), path)) {
     ViewHostMsg_OpenFile::WriteReplyParams(
         reply_msg,
 #if defined(OS_WIN)
         base::kInvalidPlatformFileValue
 #elif defined(OS_POSIX)
         base::FileDescriptor(base::kInvalidPlatformFileValue, true)
 #endif
         );
     Send(reply_msg);
     return;
@@ skipping 173 matching lines @@
       ChromeThread::IO, FROM_HERE,
       NewRunnableMethod(this, &ResourceMessageFilter::Send, reply_msg));
 }
 
 void ResourceMessageFilter::OnAsyncOpenFile(const IPC::Message& msg,
                                             const FilePath& path,
                                             int flags,
                                             int message_id) {
   DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO));
 
-  if (!ChildProcessSecurityPolicy::GetInstance()->CanUploadFile(id(), path)) {
+  if (!ChildProcessSecurityPolicy::GetInstance()->CanReadFile(id(), path)) {
     IPC::Message* reply = new ViewMsg_AsyncOpenFile_ACK(
         msg.routing_id(), base::PLATFORM_FILE_ERROR_ACCESS_DENIED,
         IPC::InvalidPlatformFileForTransit(), message_id);
     Send(reply);
     return;
   }
 
   // TODO(dumi): update this check once we have a security attribute
   // that allows renderers to modify files.
   int allowed_flags =
@@ skipping 116 matching lines @@
 
     ViewHostMsg_GetRawCookies::WriteReplyParams(reply_msg_, cookies);
     filter_->Send(reply_msg_);
     delete this;
   }
 }
 
 void GetCookiesCompletion::set_cookie_store(CookieStore* cookie_store) {
   cookie_store_ = cookie_store;
 }