Issue 343082: Reverting 30702 - Which was a Revert of 30696....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 343082: Reverting 30702 - Which was a Revert of 30696.... (Closed)

Created:
11 years, 1 month ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Reverting 30702 - Which was a Revert of 30696. See http://codereview.chromium.org/340045 for the original code. This includes a newer version of GTM that solves the problem with nib loading on 10.6. TEST=http://codereview.chromium.org/340045 BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30743

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1442 lines, -728 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/nibs/Preferences.xib	View	44 chunks	+1225 lines, -722 lines	0 comments	Download
M	chrome/browser/cocoa/preferences_window_controller.h	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/preferences_window_controller.mm	View	4 chunks	+201 lines, -5 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

LG as before