[Mac] Prefs layout work for "basics" and "personal stuff"...

[Mac] Prefs layout work for "basics" and "personal stuff"
- These two pages should now auto size vertically the labels.
  - The label should be top aligned with controls in the group when the group is taller.
  - The content should be vertically centered when the label is taller.
- All the textfields should always be tall enough to show content.
- Radios/checkbox should word wrap to show all their text.
- The spacing between groups is a little more even
- DEPS roll to pick up newer GTM with GTMIBArray.
- A bunch of changes in the XIB related to evening out spacing, adding the GTMIBArray for referencing stuff, etc.
Note: if a single radio word wraps all radios get space for that many lines, that's just how the OS does it and we aren't trying to change that (at the moment).
Note: some of the horizontal layouts can extend off the side of the window, that will be fixed in a future cl (once under the hood is also cleaned up).

TEST=see cl description for what should be working now.
BUG=20538
Committed revision 30696

[Mark Mentovai, 2009-10-30 19:15:42]

test

[Mark Mentovai, 2009-10-30 19:33:58]

LG with changes

http://codereview.chromium.org/340045/diff/14/18
File chrome/browser/cocoa/preferences_window_controller.h (right):

http://codereview.chromium.org/340045/diff/14/18#newcode43
Line 43: IBOutlet NSArray* basicsGroup1_;
It might be helpful if these were named.

basicsGroupOnStartup_, basicsGroupHomePage_, etc.?

http://codereview.chromium.org/340045/diff/14/18#newcode50
Line 50: IBOutlet NSArray* personalStuffGroup1_;
Me too!  Me too!

http://codereview.chromium.org/340045/diff/14/17
File chrome/browser/cocoa/preferences_window_controller.mm (right):

http://codereview.chromium.org/340045/diff/14/17#newcode76
Line 76: CGFloat heightChange =
:)

http://codereview.chromium.org/340045/diff/14/17#newcode114
Line 114: DCHECK_GE([views count], 2U) << "Should be atleast a label and a
control";
at<space>least

http://codereview.chromium.org/340045/diff/14/17#newcode115
Line 115: NSTextField *label = [views objectAtIndex:0];
d* l

http://codereview.chromium.org/340045/diff/14/17#newcode117
Line 117: #ifdef DEBUG
Nope.  There shouldn't be any such macro.  #ifndef NDEBUG.

http://codereview.chromium.org/340045/diff/14/17#newcode138
Line 138: if (behavior == kAutoSizeGroupBehaviorVerticalToFit) {
switch (behavior)

http://codereview.chromium.org/340045/diff/14/17#newcode159
Line 159: // NOTE: Don't worry about vertical, assume it alwalys fits.
always

http://codereview.chromium.org/340045/diff/14/17#newcode196
Line 196: // If the label grew more then then views, the other views get an
extra shift.
more than the views

[Mark Mentovai, 2009-10-30 22:19:27]

Rietveld shows this in red, but I thought I sent it.

http://codereview.chromium.org/340045/diff/2002/5003
File chrome/browser/cocoa/preferences_window_controller.mm (right):

http://codereview.chromium.org/340045/diff/2002/5003#newcode130
Line 130: #endif // DEBUG
NDEBUG

http://codereview.chromium.org/340045/diff/2002/5003#newcode373
Line 373: verticalShift = 0.0;
nit: blank line before doing the second pane.