Issue 343067: Unittest for fix to allow navigation when there is no history DB....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 343067: Unittest for fix to allow navigation when there is no history DB.... (Closed)

Created:
11 years, 1 month ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Unittest for fix to allow navigation when there is no history DB. BUG=25822 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30744

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -44 lines)			Patch
M	chrome/browser/autocomplete/history_contents_provider_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/history_url_provider_unittest.cc	View	1	4 chunks	+31 lines, -5 lines	0 comments	Download
M	chrome/browser/autocomplete/search_provider_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_index_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model_unittest.cc	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/history/history.h	View	1	3 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/history/history.cc	View	1	5 chunks	+24 lines, -18 lines	0 comments	Download
M	chrome/browser/history/history_backend.h	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/history/history_backend.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/history/history_backend_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/history_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/search_engines/template_url_model_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/testing_profile.h	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/test/testing_profile.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

11 years, 1 month ago (2009-11-02 16:20:59 UTC) #2

LGTM

http://codereview.chromium.org/343067/diff/1/4
File chrome/browser/autocomplete/history_url_provider_unittest.cc (right):

http://codereview.chromium.org/343067/diff/1/4#newcode393
Line 393: // Ensure that we can still navigate if there is no database.
still navigate -> still generate navigational results
(or something, I was confused initially by the current very general wording).

Expand Messages | Collapse Messages