Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: chrome/browser/autocomplete/history_url_provider_unittest.cc

Issue 343067: Unittest for fix to allow navigation when there is no history DB.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/history_url_provider_unittest.cc
===================================================================
--- chrome/browser/autocomplete/history_url_provider_unittest.cc (revision 30724)
+++ chrome/browser/autocomplete/history_url_provider_unittest.cc (working copy)
@@ -1,4 +1,4 @@
-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -105,10 +105,15 @@
protected:
// testing::Test
- virtual void SetUp();
+ virtual void SetUp() {
+ SetUpImpl(false);
+ }
virtual void TearDown();
- // Fills test data into the history system
+ // Does the real setup.
+ void SetUpImpl(bool no_db);
+
+ // Fills test data into the history system.
void FillData();
// Runs an autocomplete query on |text| and checks to see that the returned
@@ -130,16 +135,23 @@
scoped_refptr<HistoryURLProvider> autocomplete_;
};
+class HistoryURLProviderTestNoDB : public HistoryURLProviderTest {
+ protected:
+ virtual void SetUp() {
+ SetUpImpl(true);
+ }
+};
+
void HistoryURLProviderTest::OnProviderUpdate(bool updated_matches) {
if (autocomplete_->done())
MessageLoop::current()->Quit();
}
-void HistoryURLProviderTest::SetUp() {
+void HistoryURLProviderTest::SetUpImpl(bool no_db) {
profile_.reset(new TestingProfile());
profile_->CreateBookmarkModel(true);
profile_->BlockUntilBookmarkModelLoaded();
- profile_->CreateHistoryService(true);
+ profile_->CreateHistoryService(true, no_db);
history_service_ = profile_->GetHistoryService(Profile::EXPLICIT_ACCESS);
autocomplete_ = new HistoryURLProvider(this, profile_.get());
@@ -384,3 +396,17 @@
std::string fixup_5[] = {"http://www.17173.com/"};
RunTest(L"17173", std::wstring(), false, fixup_5, arraysize(fixup_5));
}
+
+TEST_F(HistoryURLProviderTestNoDB, NavigateWithoutDB) {
+ // Ensure that we will still produce matches for navigation when there is no
+ // database.
+ std::string navigation_1[] = {"http://test.com/"};
+ RunTest(L"test.com", std::wstring(), false, navigation_1,
+ arraysize(navigation_1));
+
+ std::string navigation_2[] = {"http://slash/"};
+ RunTest(L"slash", std::wstring(), false, navigation_2,
+ arraysize(navigation_2));
+
+ RunTest(L"this is a query", std::wstring(), false, NULL, 0);
+}

Powered by Google App Engine
This is Rietveld 408576698