Issue 343066: Now that the UI layer is accessible cross-platform, coalesce the DesktopNotif...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 343066: Now that the UI layer is accessible cross-platform, coalesce the DesktopNotif... (Closed)

Created:
11 years, 1 month ago by John Gregg

Modified:
9 years ago

Reviewers:
michaeln

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Now that the UI layer is accessible cross-platform, coalesce the DesktopNotificationService layer into one common module. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30652

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -158 lines)			Patch
M	chrome/browser/notifications/desktop_notification_service.cc	View	1 2	3 chunks	+75 lines, -1 line	0 comments	Download
D	chrome/browser/notifications/desktop_notification_service_linux.cc	View		1 chunk	+0 lines, -30 lines	0 comments	Download
D	chrome/browser/notifications/desktop_notification_service_mac.mm	View		1 chunk	+0 lines, -30 lines	0 comments	Download
D	chrome/browser/notifications/desktop_notification_service_win.cc	View		1 chunk	+0 lines, -94 lines	0 comments	Download
M	chrome/chrome.gyp	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

John Gregg

Nothing new, just moving code around, a cleanup maneuver I can do now that cross-platform ...

11 years, 1 month ago (2009-10-30 22:51:39 UTC) #1

LGTM