Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: chrome/browser/notifications/desktop_notification_service.cc

Issue 343066: Now that the UI layer is accessible cross-platform, coalesce the DesktopNotif... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/notifications/desktop_notification_service_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/desktop_notification_service.cc
===================================================================
--- chrome/browser/notifications/desktop_notification_service.cc (revision 30623)
+++ chrome/browser/notifications/desktop_notification_service.cc (working copy)
@@ -6,12 +6,15 @@
#include "app/l10n_util.h"
#include "app/resource_bundle.h"
+#include "base/string_piece.h"
+#include "base/string_util.h"
#include "base/thread.h"
#include "chrome/browser/browser_list.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/chrome_thread.h"
#include "chrome/browser/notifications/notification.h"
#include "chrome/browser/notifications/notification_object_proxy.h"
+#include "chrome/browser/notifications/notification_ui_manager.h"
#include "chrome/browser/notifications/notifications_prefs_cache.h"
#include "chrome/browser/profile.h"
#include "chrome/browser/renderer_host/render_process_host.h"
@@ -24,13 +27,50 @@
#include "chrome/common/pref_names.h"
#include "chrome/common/pref_service.h"
#include "chrome/common/render_messages.h"
-#include "webkit/api/public/WebNotificationPresenter.h"
+#include "grit/browser_resources.h"
#include "grit/chromium_strings.h"
#include "grit/generated_resources.h"
#include "grit/theme_resources.h"
+#include "webkit/api/public/WebNotificationPresenter.h"
using WebKit::WebNotificationPresenter;
+// Creates a data:xxxx URL which contains the full HTML for a notification
+// using supplied icon, title, and text, run through a template which contains
+// the standard formatting for notifications.
+static string16 CreateDataUrl(const GURL& icon_url, const string16& title,
+ const string16& body) {
+ const base::StringPiece template_html(
+ ResourceBundle::GetSharedInstance().GetRawDataResource(
+ IDR_NOTIFICATION_HTML));
+
+ if (template_html.empty()) {
+ NOTREACHED() << "unable to load template. ID: " << IDR_NOTIFICATION_HTML;
+ return EmptyString16();
+ }
+
+ std::vector<string16> subst;
+ if (icon_url.is_valid())
+ subst.push_back(UTF8ToUTF16(icon_url.spec()));
+ else
+ subst.push_back(EmptyString16());
+
+ subst.push_back(title);
+ subst.push_back(body);
+
+ if (icon_url.is_valid()) {
+ subst.push_back(ASCIIToUTF16("block"));
+ subst.push_back(ASCIIToUTF16("60"));
+ } else {
+ subst.push_back(ASCIIToUTF16("none"));
+ subst.push_back(ASCIIToUTF16("5"));
+ }
+
+ string16 format_string = ASCIIToUTF16("data:text/html;charset=utf-8,"
+ + template_html.as_string());
+ return ReplaceStringPlaceholders(format_string, subst, NULL);
+}
+
// A task object which calls the renderer to inform the web page that the
// permission request has completed.
class NotificationPermissionCallbackTask : public Task {
@@ -228,3 +268,37 @@
tab->AddInfoBar(new NotificationPermissionInfoBarDelegate(tab, origin,
callback_context));
}
+
+void DesktopNotificationService::ShowNotification(
+ const Notification& notification) {
+ ui_manager_->Add(notification, profile_);
+}
+
+bool DesktopNotificationService::ShowDesktopNotification(
+ const GURL& origin, const GURL& url, int process_id, int route_id,
+ NotificationSource source, int notification_id) {
+ DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI));
+ NotificationObjectProxy* proxy =
+ new NotificationObjectProxy(process_id, route_id,
+ notification_id,
+ source == WorkerNotification);
+ Notification notif(origin, url, proxy);
+ ShowNotification(notif);
+ return true;
+}
+
+bool DesktopNotificationService::ShowDesktopNotificationText(
+ const GURL& origin, const GURL& icon, const string16& title,
+ const string16& text, int process_id, int route_id,
+ NotificationSource source, int notification_id) {
+ DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI));
+ NotificationObjectProxy* proxy =
+ new NotificationObjectProxy(process_id, route_id,
+ notification_id,
+ source == WorkerNotification);
+ // "upconvert" the string parameters to a data: URL.
+ string16 data_url = CreateDataUrl(icon, title, text);
+ Notification notif(origin, GURL(data_url), proxy);
+ ShowNotification(notif);
+ return true;
+}
« no previous file with comments | « no previous file | chrome/browser/notifications/desktop_notification_service_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698