Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: chrome/browser/cocoa/bookmark_editor_controller_unittest.mm

Issue 343042: Original discussion in CL for 337010. See http://codereview.chromium.org/337... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/bookmark_editor_controller_unittest.mm
===================================================================
--- chrome/browser/cocoa/bookmark_editor_controller_unittest.mm (revision 30403)
+++ chrome/browser/cocoa/bookmark_editor_controller_unittest.mm (working copy)
@@ -255,8 +255,6 @@
[default_controller_ setDisplayName:@"NEW NAME"];
[default_controller_ ok:nil];
const BookmarkNode* newParent = bookmark_bb_3_->GetParent();
- std::cout << "oldParent: " << oldParent->GetTitle() << "\r";
- std::cout << "newParent: " << newParent->GetTitle() << "\r";
ASSERT_EQ(newParent, oldParent);
int childIndex = newParent->IndexOfChild(bookmark_bb_3_);
ASSERT_EQ(3, childIndex);
@@ -292,6 +290,14 @@
EXPECT_EQ(bookmark_bb_3_->GetTitle(), L"NEW NAME");
}
+TEST_F(BookmarkEditorControllerTreeTest, AddFolderWithGroupSelected) {
+ [default_controller_ newFolder:nil];
+ [default_controller_ cancel:nil];
+ EXPECT_EQ(6, group_bb_->GetChildCount());
+ const BookmarkNode* folderChild = group_bb_->GetChild(5);
+ EXPECT_EQ(folderChild->GetTitle(), L"New folder");
+}
+
class BookmarkEditorControllerTreeNoNodeTest :
public BookmarkEditorControllerTreeTest {
public:
@@ -318,3 +324,29 @@
EXPECT_EQ(new_node->GetURL(), GURL("http://NEWURL.com"));
}
+class BookmarkEditorControllerTreeNoParentTest :
+ public BookmarkEditorControllerTreeTest {
+ public:
+ BookmarkEditorControllerTreeNoParentTest() {
+ // Reset the controller so that we have no |node|.
+ default_controller_.reset([[BookmarkEditorController alloc]
+ initWithParentWindow:cocoa_helper_.window()
+ profile:helper_.profile()
+ parent:nil
+ node:nil
+ configuration:BookmarkEditor::SHOW_TREE
+ handler:nil]);
+ [default_controller_ window]; // Forces a nib load
+ }
+};
+
+TEST_F(BookmarkEditorControllerTreeNoParentTest, AddFolderWithNoGroupSelected) {
+ [default_controller_ newFolder:nil];
+ [default_controller_ cancel:nil];
+ BookmarkModel* model = helper_.profile()->GetBookmarkModel();
+ const BookmarkNode* bookmarkBar = model->GetBookmarkBarNode();
+ EXPECT_EQ(5, bookmarkBar->GetChildCount());
+ const BookmarkNode* folderChild = bookmarkBar->GetChild(4);
+ EXPECT_EQ(folderChild->GetTitle(), L"New folder");
+}
+
« no previous file with comments | « chrome/browser/cocoa/bookmark_editor_controller.mm ('k') | chrome/browser/cocoa/bookmark_tree_browser_cell.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698