Chromium Code Reviews

Side by Side Diff: chrome/browser/cocoa/bookmark_editor_controller_unittest.mm

Issue 343042: Original discussion in CL for 337010. See http://codereview.chromium.org/337... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <Cocoa/Cocoa.h> 5 #import <Cocoa/Cocoa.h>
6 6
7 #include "base/scoped_nsobject.h" 7 #include "base/scoped_nsobject.h"
8 #include "base/sys_string_conversions.h" 8 #include "base/sys_string_conversions.h"
9 #import "chrome/browser/cocoa/bookmark_editor_controller.h" 9 #import "chrome/browser/cocoa/bookmark_editor_controller.h"
10 #include "chrome/browser/cocoa/browser_test_helper.h" 10 #include "chrome/browser/cocoa/browser_test_helper.h"
(...skipping 237 matching lines...)
248 248
249 child = root.GetChild(3); 249 child = root.GetChild(3);
250 EXPECT_EQ(0, child->GetChildCount()); 250 EXPECT_EQ(0, child->GetChildCount());
251 } 251 }
252 252
253 TEST_F(BookmarkEditorControllerTreeTest, RenameBookmarkInPlace) { 253 TEST_F(BookmarkEditorControllerTreeTest, RenameBookmarkInPlace) {
254 const BookmarkNode* oldParent = bookmark_bb_3_->GetParent(); 254 const BookmarkNode* oldParent = bookmark_bb_3_->GetParent();
255 [default_controller_ setDisplayName:@"NEW NAME"]; 255 [default_controller_ setDisplayName:@"NEW NAME"];
256 [default_controller_ ok:nil]; 256 [default_controller_ ok:nil];
257 const BookmarkNode* newParent = bookmark_bb_3_->GetParent(); 257 const BookmarkNode* newParent = bookmark_bb_3_->GetParent();
258 std::cout << "oldParent: " << oldParent->GetTitle() << "\r";
259 std::cout << "newParent: " << newParent->GetTitle() << "\r";
260 ASSERT_EQ(newParent, oldParent); 258 ASSERT_EQ(newParent, oldParent);
261 int childIndex = newParent->IndexOfChild(bookmark_bb_3_); 259 int childIndex = newParent->IndexOfChild(bookmark_bb_3_);
262 ASSERT_EQ(3, childIndex); 260 ASSERT_EQ(3, childIndex);
263 } 261 }
264 262
265 TEST_F(BookmarkEditorControllerTreeTest, ChangeBookmarkURLInPlace) { 263 TEST_F(BookmarkEditorControllerTreeTest, ChangeBookmarkURLInPlace) {
266 const BookmarkNode* oldParent = bookmark_bb_3_->GetParent(); 264 const BookmarkNode* oldParent = bookmark_bb_3_->GetParent();
267 [default_controller_ setDisplayURL:@"http://NEWURL.com"]; 265 [default_controller_ setDisplayURL:@"http://NEWURL.com"];
268 [default_controller_ ok:nil]; 266 [default_controller_ ok:nil];
269 const BookmarkNode* newParent = bookmark_bb_3_->GetParent(); 267 const BookmarkNode* newParent = bookmark_bb_3_->GetParent();
(...skipping 15 matching lines...)
285 [default_controller_ setDisplayName:@"NEW NAME"]; 283 [default_controller_ setDisplayName:@"NEW NAME"];
286 [default_controller_ selectTestNodeInBrowser:group_c_]; 284 [default_controller_ selectTestNodeInBrowser:group_c_];
287 [default_controller_ ok:nil]; 285 [default_controller_ ok:nil];
288 const BookmarkNode* parent = bookmark_bb_3_->GetParent(); 286 const BookmarkNode* parent = bookmark_bb_3_->GetParent();
289 ASSERT_EQ(parent, group_c_); 287 ASSERT_EQ(parent, group_c_);
290 int childIndex = parent->IndexOfChild(bookmark_bb_3_); 288 int childIndex = parent->IndexOfChild(bookmark_bb_3_);
291 ASSERT_EQ(4, childIndex); 289 ASSERT_EQ(4, childIndex);
292 EXPECT_EQ(bookmark_bb_3_->GetTitle(), L"NEW NAME"); 290 EXPECT_EQ(bookmark_bb_3_->GetTitle(), L"NEW NAME");
293 } 291 }
294 292
293 TEST_F(BookmarkEditorControllerTreeTest, AddFolderWithGroupSelected) {
294 [default_controller_ newFolder:nil];
295 [default_controller_ cancel:nil];
296 EXPECT_EQ(6, group_bb_->GetChildCount());
297 const BookmarkNode* folderChild = group_bb_->GetChild(5);
298 EXPECT_EQ(folderChild->GetTitle(), L"New folder");
299 }
300
295 class BookmarkEditorControllerTreeNoNodeTest : 301 class BookmarkEditorControllerTreeNoNodeTest :
296 public BookmarkEditorControllerTreeTest { 302 public BookmarkEditorControllerTreeTest {
297 public: 303 public:
298 BookmarkEditorControllerTreeNoNodeTest() { 304 BookmarkEditorControllerTreeNoNodeTest() {
299 // Reset the controller so that we have no |node|. 305 // Reset the controller so that we have no |node|.
300 default_controller_.reset([[BookmarkEditorController alloc] 306 default_controller_.reset([[BookmarkEditorController alloc]
301 initWithParentWindow:cocoa_helper_.window() 307 initWithParentWindow:cocoa_helper_.window()
302 profile:helper_.profile() 308 profile:helper_.profile()
303 parent:group_bb_ 309 parent:group_bb_
304 node:nil 310 node:nil
305 configuration:BookmarkEditor::SHOW_TREE 311 configuration:BookmarkEditor::SHOW_TREE
306 handler:nil]); 312 handler:nil]);
307 [default_controller_ window]; // Forces a nib load 313 [default_controller_ window]; // Forces a nib load
308 } 314 }
309 }; 315 };
310 316
311 TEST_F(BookmarkEditorControllerTreeNoNodeTest, NewBookmarkNoNode) { 317 TEST_F(BookmarkEditorControllerTreeNoNodeTest, NewBookmarkNoNode) {
312 [default_controller_ setDisplayName:@"NEW BOOKMARK"]; 318 [default_controller_ setDisplayName:@"NEW BOOKMARK"];
313 [default_controller_ setDisplayURL:@"http://NEWURL.com"]; 319 [default_controller_ setDisplayURL:@"http://NEWURL.com"];
314 [default_controller_ ok:nil]; 320 [default_controller_ ok:nil];
315 const BookmarkNode* new_node = group_bb_->GetChild(5); 321 const BookmarkNode* new_node = group_bb_->GetChild(5);
316 ASSERT_EQ(0, new_node->GetChildCount()); 322 ASSERT_EQ(0, new_node->GetChildCount());
317 EXPECT_EQ(new_node->GetTitle(), L"NEW BOOKMARK"); 323 EXPECT_EQ(new_node->GetTitle(), L"NEW BOOKMARK");
318 EXPECT_EQ(new_node->GetURL(), GURL("http://NEWURL.com")); 324 EXPECT_EQ(new_node->GetURL(), GURL("http://NEWURL.com"));
319 } 325 }
320 326
327 class BookmarkEditorControllerTreeNoParentTest :
328 public BookmarkEditorControllerTreeTest {
329 public:
330 BookmarkEditorControllerTreeNoParentTest() {
331 // Reset the controller so that we have no |node|.
332 default_controller_.reset([[BookmarkEditorController alloc]
333 initWithParentWindow:cocoa_helper_.window()
334 profile:helper_.profile()
335 parent:nil
336 node:nil
337 configuration:BookmarkEditor::SHOW_TREE
338 handler:nil]);
339 [default_controller_ window]; // Forces a nib load
340 }
341 };
342
343 TEST_F(BookmarkEditorControllerTreeNoParentTest, AddFolderWithNoGroupSelected) {
344 [default_controller_ newFolder:nil];
345 [default_controller_ cancel:nil];
346 BookmarkModel* model = helper_.profile()->GetBookmarkModel();
347 const BookmarkNode* bookmarkBar = model->GetBookmarkBarNode();
348 EXPECT_EQ(5, bookmarkBar->GetChildCount());
349 const BookmarkNode* folderChild = bookmarkBar->GetChild(4);
350 EXPECT_EQ(folderChild->GetTitle(), L"New folder");
351 }
352
OLDNEW
« no previous file with comments | « chrome/browser/cocoa/bookmark_editor_controller.mm ('k') | chrome/browser/cocoa/bookmark_tree_browser_cell.h » ('j') | no next file with comments »

Powered by Google App Engine