Added printing of a couple of links to documentation in case warnings are rep...

Added printing of a couple of links to documentation in case warnings are reporteed.
I think this may increase the popularity and usability of our tools.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30246

[stuartmorgan, 2009-10-27 20:28:27]

http://codereview.chromium.org/343002/diff/4/5
File tools/valgrind/valgrind_test.py (right):

http://codereview.chromium.org/343002/diff/4/5#newcode373
Line 373: return ret
The return value is non-zero if there are leaks or invalid reads; why do we need
to tell people how to use valgrind if it's run correctly but finds problems?

[Timur Iskhodzhanov, 2009-10-27 20:37:47]

Well the docs also explain the format of the reports, what are suppressions,
where they are written etc.
I guess this may help someone who is not very familiar with Valgrind.

I've recently bumped into a question "what is ThreadSanitizer and do we need it
on the main waterfall if it becomes red?".
The question was asked by a developer who commited a changelist hanging on
ThreadSanitizer bot (the bug was in ThreadSanitizer). After talking to this
developer he found out about the tool and what has happened. Also, I've
convinced him TSAN is useful after giving him a link to the doc.
However, the bot remained red for a few hours. I guess this could have been
fixed faster and easier.
That's the reason why I'm trying to add some links to docs.

On 2009/10/27 20:28:27, stuartmorgan wrote:
> http://codereview.chromium.org/343002/diff/4/5
> File tools/valgrind/valgrind_test.py (right):
> 
> http://codereview.chromium.org/343002/diff/4/5#newcode373
> Line 373: return ret
> The return value is non-zero if there are leaks or invalid reads; why do we
need
> to tell people how to use valgrind if it's run correctly but finds problems?

[stuartmorgan, 2009-10-27 20:52:40]

Fair enough; LGTM

[not_the_right_dank, 2009-10-28 16:36:45]

Heck, may as well print the message unconditionally at the beginning
or end of every log.

But make it briefer, e.g.
  See http://dev.chromium.org/developers/how-tos/using-valgrind
  if you're not familiar with using Valgrind on Chromium.


On Tue, Oct 27, 2009 at 1:37 PM,  <timurrrr@chromium.org> wrote:
>
> Well the docs also explain the format of the reports, what are suppressions,
> where they are written etc.
> I guess this may help someone who is not very familiar with Valgrind.
>
> I've recently bumped into a question "what is ThreadSanitizer and do we need
> it
> on the main waterfall if it becomes red?".
> The question was asked by a developer who commited a changelist hanging on
> ThreadSanitizer bot (the bug was in ThreadSanitizer). After talking to this
> developer he found out about the tool and what has happened. Also, I've
> convinced him TSAN is useful after giving him a link to the doc.
> However, the bot remained red for a few hours. I guess this could have been
> fixed faster and easier.
> That's the reason why I'm trying to add some links to docs.
>
> On 2009/10/27 20:28:27, stuartmorgan wrote:
>>
>> http://codereview.chromium.org/343002/diff/4/5
>> File tools/valgrind/valgrind_test.py (right):
>
>> http://codereview.chromium.org/343002/diff/4/5#newcode373
>> Line 373: return ret
>> The return value is non-zero if there are leaks or invalid reads; why do
>> we
>
> need
>>
>> to tell people how to use valgrind if it's run correctly but finds
>> problems?
>
>
>
> http://codereview.chromium.org/343002
>