Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 342116: Attempt 2 at:... (Closed)

Created:
11 years, 1 month ago by sky
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, Erik does not do reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Attempt 2 at: Gets find bar animation/clipping to work on views/gtk. The only difference between this and the first version is fixing an include in extension_host that was triggering mac to build views, as well as an extraneous SetSlideDuration I had used for testing. BUG=none TEST=none TBR=ben Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30942

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -162 lines) Patch
M app/app.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M app/gfx/native_widget_types.h View 3 chunks +3 lines, -0 lines 0 comments Download
M app/gfx/path.h View 1 chunk +28 lines, -15 lines 0 comments Download
A + app/gfx/path.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M app/gfx/path_gtk.cc View 2 chunks +22 lines, -1 line 0 comments Download
M app/gfx/path_win.cc View 2 chunks +22 lines, -1 line 0 comments Download
M app/win_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M base/scoped_handle.h View 1 chunk +2 lines, -0 lines 0 comments Download
A + base/scoped_handle_gtk.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M base/scoped_handle_win.h View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/dock_info_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/blocked_popup_container_view_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/find_bar_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/find_bar_host.cc View 3 chunks +114 lines, -0 lines 0 comments Download
M chrome/browser/views/find_bar_host_gtk.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/views/find_bar_host_win.cc View 1 chunk +0 lines, -111 lines 0 comments Download
M chrome/browser/views/notifications/balloon_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/view.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M views/widget/widget.h View 1 chunk +2 lines, -2 lines 0 comments Download
M views/widget/widget_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M views/widget/widget_gtk.cc View 1 chunk +1 line, -3 lines 0 comments Download
M views/widget/widget_win.h View 1 chunk +1 line, -1 line 0 comments Download
M views/widget/widget_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M views/window/window_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/window/window_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
11 years, 1 month ago (2009-11-04 05:06:54 UTC) #1
Ben Goodger (Google)
11 years, 1 month ago (2009-11-04 06:07:25 UTC) #2
OK

On Tue, Nov 3, 2009 at 10:06 PM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger,
>
> Description:
> Attempt 2 at:
>
> Gets find bar animation/clipping to work on views/gtk.
>
> The only difference between this and the first version is fixing an
> include in extension_host that was triggering mac to build views, as
> well as an extraneous SetSlideDuration I had used for testing.
>
> BUG=none
> TEST=none
> TBR=ben
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30942
>
> Please review this at http://codereview.chromium.org/342116
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     app/app.gyp
>  M     app/gfx/native_widget_types.h
>  M     app/gfx/path.h
>  A  +  app/gfx/path.cc
>  M     app/gfx/path_gtk.cc
>  M     app/gfx/path_win.cc
>  M     app/win_util.h
>  M     base/base.gyp
>  M     base/scoped_handle.h
>  A  +  base/scoped_handle_gtk.h
>  M     base/scoped_handle_win.h
>  M     chrome/browser/dock_info_win.cc
>  M     chrome/browser/extensions/extension_host.cc
>  M
> chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
>  M     chrome/browser/views/blocked_popup_container_view_views.cc
>  M     chrome/browser/views/find_bar_host.h
>  M     chrome/browser/views/find_bar_host.cc
>  M     chrome/browser/views/find_bar_host_gtk.cc
>  M     chrome/browser/views/find_bar_host_win.cc
>  M     chrome/browser/views/notifications/balloon_view.cc
>  M     views/view.cc
>  M     views/widget/widget.h
>  M     views/widget/widget_gtk.h
>  M     views/widget/widget_gtk.cc
>  M     views/widget/widget_win.h
>  M     views/widget/widget_win.cc
>  M     views/window/window_gtk.cc
>  M     views/window/window_win.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698