Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1384)

Issue 3421039: Revert 60739 (still leaks on ChromiumOS!) - Reland r59972: Eagerly set the IO... (Closed)

Created:
10 years, 2 months ago by willchan no longer on Chromium
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Revert 60739 (still leaks on ChromiumOS!) - Reland r59972: Eagerly set the IO loop used for OCSP. ChromeOS will create a special Profile for login. Previously, OCSP initialization was done for the "default" ChromeURLRequestContext for each Profile. Since we can have multiple profiles, this causes the initialization (and uninitialization) to happen multiple times, which causes problems for OCSP since we use statics. The solution is to identify the "main" Profile. We create said Profile in BrowserMain. I add an "is_main_" variable to URLRequestContextGetter and URLRequestContext, so that only the "main" URLRequestContext will initialize OCSP. The only change from r59972 is the location that I set_is_main(). I set it when we set the default request context. This is because, by the time I had called set_is_main() in BrowserMain, the ChromeURLRequestContextGetter was already created (it gets created during the CreateProfile() function). So I was too late. BUG=55940 TEST=Manual Review URL: http://codereview.chromium.org/3391028 TBR=willchan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60753

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -223 lines) Patch
M chrome/browser/browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/io_thread.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 3 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/profile_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/net/url_request_context_getter.h View 2 chunks +1 line, -17 lines 0 comments Download
M net/ocsp/nss_ocsp.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/ocsp/nss_ocsp.cc View 7 chunks +90 lines, -170 lines 0 comments Download
M net/url_request/url_request_context.h View 2 chunks +0 lines, -8 lines 0 comments Download
M net/url_request/url_request_context.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
willchan no longer on Chromium
10 years, 2 months ago (2010-09-28 04:52:03 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698