Reland r59972: Eagerly set the IO loop used for OCSP.

Reland r59972: Eagerly set the IO loop used for OCSP.

ChromeOS will create a special Profile for login. Previously, OCSP initialization was done for the "default" ChromeURLRequestContext for each Profile. Since we can have multiple profiles, this causes the initialization (and uninitialization) to happen multiple times, which causes problems for OCSP since we use statics. The solution is to identify the "main" Profile. We create said Profile in BrowserMain. I add an "is_main_" variable to URLRequestContextGetter and URLRequestContext, so that only the "main" URLRequestContext will initialize OCSP.

The only change from r59972 is the location that I set_is_main().  I set it when we set the default request context.  This is because, by the time I had called set_is_main() in BrowserMain, the ChromeURLRequestContextGetter was already created (it gets created during the CreateProfile() function).  So I was too late.

BUG=55940
TEST=Manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60739

[willchan no longer on Chromium, 2010-09-27 23:03:37]

I'm still waiting for my valgrind run to finish.  It's been running for 12 hours
now, so I'm not sure if it'll finish :P  But from my debugging, I think I've
narrowed down the cause.

[wtc, 2010-09-27 23:58:19]

LGTM.  I'm glad you tracked this down.

Do you think "is_default" is better than "is_main"?  Just a
thought.  No need to let this renaming delay the relanding.

I have two minor fixes below.

http://codereview.chromium.org/3391028/diff/2001/3001
File chrome/browser/browser_main.cc (right):

http://codereview.chromium.org/3391028/diff/2001/3001#newcode52
chrome/browser/browser_main.cc:52: #include
"chrome/browser/net/chrome_url_request_context.h"
Nit: remove "chrome/browser/net/chrome_url_request_context.h".
It's no longer needed.

http://codereview.chromium.org/3391028/diff/2001/3005
File chrome/browser/profile_impl.cc (right):

http://codereview.chromium.org/3391028/diff/2001/3005#newcode710
chrome/browser/profile_impl.cc:710: default_request_context_ = request_context_;
I am not familiar with this code, but this does seem like the
earliest possible time we know a request context is marked as
the default/main request context.

http://codereview.chromium.org/3391028/diff/2001/3006
File chrome/common/net/url_request_context_getter.h (right):

http://codereview.chromium.org/3391028/diff/2001/3006#newcode44
chrome/common/net/url_request_context_getter.h:44: void set_is_main(bool
is_main) { is_main_ = is_main; }
Nice catch.  On the other hand, since you only pass 'true'
to set_is_main, the original code should not have caused a
bug.

BUG: the set_is_main() method in net/url_request/url_request_context.h
needs the same fix.