Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 342081: Add suppressions for leaks in sync unit tests after adding ChromeThread insta... (Closed)

Created:
11 years, 1 month ago by jam
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, not_the_right_glider, Nirnimesh, Timur Iskhodzhanov, dank, stuartmorgan, pam+watch_chromium.org
Visibility:
Public.

Description

Add suppressions for leaks in sync unit tests after adding ChromeThread instances. BUG=26493 TBR=tim Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30728

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
11 years, 1 month ago (2009-11-02 18:59:38 UTC) #1
ncarter (slow)
11 years, 1 month ago (2009-11-03 00:49:59 UTC) #2
LGTM.

On Mon, Nov 2, 2009 at 10:59 AM, <jam@chromium.org> wrote:

>
> Reviewers: timsteele,
>
> Description:
> Add suppressions for leaks in sync unit tests after adding ChromeThread
> instances.
>
> BUG=26493
> TBR=tim
>
> Please review this at http://codereview.chromium.org/342081
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/memcheck/suppressions.txt
>
>
> Index: tools/valgrind/memcheck/suppressions.txt
> ===================================================================
> --- tools/valgrind/memcheck/suppressions.txt    (revision 30688)
> +++ tools/valgrind/memcheck/suppressions.txt    (working copy)
> @@ -1073,3 +1073,42 @@
>    fun:_ZN9Extension25LoadExtensionActionHelperEPK15DictionaryValuePSs
>    fun:_ZN39ExtensionTest_LoadPageActionHelper_Test8TestBodyEv
>  }
> +{
> +   bug_26493
> +   Memcheck:Leak
> +   fun:_Znw*
> +
>
fun:_ZN12browser_sync6SyncerC1EPN8syncable16DirectoryManagerERKSsPNS_23ServerConnectionManagerEPNS_15ModelSafeWorkerE
> +
>
fun:_ZN12browser_sync12SyncerThread27HandleDirectoryManagerEventERKN8syncable21DirectoryManagerEventE
> +
>
fun:_ZN12SimpleHookupI12EventChannelIN8syncable21DirectoryManagerEventE4Lock8AutoLockES2_N12browser_sync12SyncerThreadEMS7_FvRKS2_EE8CallbackES9_
> +
>
fun:_ZN23EventListenerHookupImplI12EventChannelIN8syncable21DirectoryManagerEventE4Lock8AutoLockES2_12SimpleHookupIS5_S2_N12browser_sync12SyncerThreadEMS8_FvRKS2_EEE11HandleEventESA_
> +
>
fun:_ZN12EventChannelIN8syncable21DirectoryManagerEventE4Lock8AutoLockE15NotifyListenersERKS1_
> +   fun:_ZN8syncable16DirectoryManager4OpenERKSs
> +   fun:_ZN8sync_api11SyncManager12SyncInternal16SetupForTestModeEPKt
> +   fun:_ZN8sync_api11SyncManager16SetupForTestModeEPKt
> +
>
fun:_ZN12browser_sync15SyncBackendHost4Core19DoInitializeForTestEPNS_19BookmarkModelWorkerERKSbIwSt11char_traitsIwESaIwEEPN8sync_api23HttpPostProviderFactoryESC_
> +
>
fun:_Z16DispatchToMethodIN12browser_sync15SyncBackendHost4CoreEMS2_FvPNS0_19BookmarkModelWorkerERKSbIwSt11char_traitsIwESaIwEEPN8sync_api23HttpPostProviderFactoryESD_ES4_S8_SD_SD_EvPT_T0_RK6Tuple4IT1_T2_T3_T4_E
> +
>
fun:_ZN14RunnableMethodIN12browser_sync15SyncBackendHost4CoreEMS2_FvPNS0_19BookmarkModelWorkerERKSbIwSt11char_traitsIwESaIwEEPN8sync_api23HttpPostProviderFactoryESD_E6Tuple4IS4_S8_SD_SD_EE3RunEv
> +   fun:_ZN11MessageLoop7RunTaskEP4Task
> +   fun:_ZN11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE
> +   fun:_ZN11MessageLoop6DoWorkEv
> +   fun:_ZN4base18MessagePumpDefault3RunEPNS_11MessagePump8DelegateE
> +   fun:_ZN11MessageLoop11RunInternalEv
> +   fun:_ZN11MessageLoop10RunHandlerEv
> +}
> +{
> +   bug_26493
> +   Memcheck:Leak
> +   fun:_Znw*
> +
>
fun:_ZN9__gnu_cxx13new_allocatorIN21NotificationRegistrar6RecordEE8allocateEjPKv
> +
>
fun:_ZNSt12_Vector_baseIN21NotificationRegistrar6RecordESaIS1_EE11_M_allocateEj
> +
>
fun:_ZNSt6vectorIN21NotificationRegistrar6RecordESaIS1_EE13_M_insert_auxEN9__gnu_cxx17__normal_iteratorIPS1_S3_EERKS1_
> +
> fun:_ZNSt6vectorIN21NotificationRegistrar6RecordESaIS1_EE9push_backERKS1_
> +
>
fun:_ZN21NotificationRegistrar3AddEP20NotificationObserver16NotificationTypeRK18NotificationSource
> +
>
fun:_ZN12browser_sync139_GLOBAL__N__b_slave_chromium_rel_linux_valgrind_builder_build_src_chrome_browser_sync_util_extensions_activity_monitor.cc_00000000_90D7379F16RegistrationTask3RunEv
> +   fun:_ZN11MessageLoop7RunTaskEP4Task
> +   fun:_ZN11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE
> +   fun:_ZN11MessageLoop6DoWorkEv
> +   fun:_ZN4base18MessagePumpDefault3RunEPNS_11MessagePump8DelegateE
> +   fun:_ZN11MessageLoop11RunInternalEv
> +   fun:_ZN11MessageLoop10RunHandlerEv
> +}
>
>
>

Powered by Google App Engine
This is Rietveld 408576698