Issue 342043: Connect the various pieces for notifications... hook up NotificationUIManager...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 342043: Connect the various pieces for notifications... hook up NotificationUIManager... (Closed)

Created:
11 years, 1 month ago by John Gregg

Modified:
9 years ago

Reviewers:
michaeln

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, jam, pam+watch_chromium.org, Paweł Hajdan Jr., darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Connect the various pieces for notifications... hook up NotificationUIManager to BrowserProcess to DesktopNotificationService to RenderView. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30557

Patch Set 1 #

Patch Set 2 : remove stale TODO #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+180 lines, -12 lines)			Patch
M	chrome/browser/browser_process.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_process_impl.h	View		3 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_process_impl.cc	View		3 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/desktop_notification_service.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/notifications/desktop_notification_service_win.cc	View		3 chunks	+2 lines, -5 lines	0 comments	Download
A	chrome/browser/notifications/notification_ui_manager.h	View		1 chunk	+66 lines, -0 lines	0 comments	Download
A	chrome/browser/notifications/notification_ui_manager.cc	View		1 chunk	+77 lines, -0 lines	0 comments	Download
M	chrome/browser/profile.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/chrome.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_view.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/testing_browser_process.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

John Gregg

I broke up that earlier big "notifications ui" patch into the views part (which BenG ...

11 years, 1 month ago (2009-10-29 21:13:43 UTC) #1

michaeln

LGTM... there are a couple of "Could not find a newline character at the end ...

11 years, 1 month ago (2009-10-30 00:35:05 UTC) #2

John Gregg

11 years, 1 month ago (2009-10-30 00:37:39 UTC) #3

On 2009/10/30 00:35:05, michaeln wrote:
> LGTM... there are a couple of "Could not find a newline character at the end
of
> the file" lint errors.

I see that but it's bizarre.  I double-checked all those files and they end with
newlines, and local lint doesn't complain.

Expand Messages | Collapse Messages