chrome/browser/notifications/desktop_notification_service_win.cc - Issue 342043: Connect the various pieces for notifications... hook up NotificationUIManager...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/desktop_notification_service_win.cc

Issue 342043: Connect the various pieces for notifications... hook up NotificationUIManager... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: remove stale TODO Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/desktop_notification_service.h ('k') | chrome/browser/notifications/notification_ui_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/desktop_notification_service_win.cc

===================================================================

--- chrome/browser/notifications/desktop_notification_service_win.cc (revision 30470)

+++ chrome/browser/notifications/desktop_notification_service_win.cc (working copy)

@@ -12,9 +12,9 @@

#include "chrome/browser/browser_list.h"

#include "chrome/browser/chrome_thread.h"

#include "chrome/browser/notifications/notification_object_proxy.h"

+#include "chrome/browser/notifications/notification_ui_manager.h"

#include "chrome/browser/renderer_host/render_process_host.h"

#include "chrome/browser/renderer_host/site_instance.h"

-#include "chrome/browser/worker_host/worker_process_host.h"

#include "chrome/common/child_process_host.h"

#include "grit/browser_resources.h"

#include "grit/generated_resources.h"

@@ -59,9 +59,7 @@

// put the notification with the requested parameters on the desktop.

void DesktopNotificationService::ShowNotification(

const Notification& notification) {

- SiteInstance* site_instance = SiteInstance::CreateSiteInstance(profile_);

- // TODO(johnnyg): When UI Manager is available, add from here.

- // ui_manager_->Add(notification, profile_, site_instance);

+ ui_manager_->Add(notification, profile_);

}

// Shows a notification bubble which contains the contents of url.

@@ -94,4 +92,3 @@

ShowNotification(notif);

return true;

}