Issue 342008: Make drover works in cygwin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 342008: Make drover works in cygwin. (Closed)

Created:
11 years, 1 month ago by Nicolas Sylvain

Modified:
9 years, 7 months ago

Reviewers:
laforge, chase

CC:
chromium-reviews_googlegroups.com, M-A Ruel

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Make drover works in cygwin. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30285

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	drover	View	1	1 chunk	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

chase

http://codereview.chromium.org/342008/diff/1/2 File drover (right): http://codereview.chromium.org/342008/diff/1/2#newcode9 Line 9: script=drover This line can be removed after the ...

11 years, 1 month ago (2009-10-27 23:30:11 UTC) #3

Nicolas Sylvain

11 years, 1 month ago (2009-10-28 15:23:26 UTC) #5

new version updated, thanks for the drive-by review.

please take a look

Nicolas


On Tue, Oct 27, 2009 at 4:30 PM, <chase@chromium.org> wrote:

>
> http://codereview.chromium.org/342008/diff/1/2
> File drover (right):
>
> http://codereview.chromium.org/342008/diff/1/2#newcode9
> Line 9: script=drover
> This line can be removed after the other sections are updated.
>
> http://codereview.chromium.org/342008/diff/1/2#newcode13
> Line 13: $0.bat "$@"
> drover-as-checked-in differs from other tools here.  This is a good
> opportunity to unify them: $0.bat -> ${base_dir}/drover.bat
>
> http://codereview.chromium.org/342008/diff/1/2#newcode26
> Line 26: exec python "$base_dir/$script.py" "$@"
> another opportunity to unify: $script -> drover
>
>
> http://codereview.chromium.org/342008
>

Expand Messages | Collapse Messages