Save passwords for HTTP+FTP authentication....

Save passwords for HTTP+FTP authentication.

Rather than modifying the PasswordForm to have a username_element and password_element, change the logic in PasswordFormManager::HasValidPasswordForm to only care about empty username_element and password_element for HTML-form based PasswordForms.

BUG=5236, 49894
TEST=unit_tests --gtest_filter="*TestValidForms*". Manual: Start Chrome with fresh profile, go to a Digest authenticating proxy or server and enter a username+password. After page loads successfully, click "save password" in the infobar. Restart chrome with the same profile, and make sure username+password dialog prompt is filled in.

 

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60171

[cbentzel, 2010-09-21 19:01:23]

My previous change worked correctly, but this was a suggested improvement which
does not change the storage of the non-HTML forms in the sqlite db.

[Mike Mammarella, 2010-09-21 20:06:00]

On 2010/09/21 19:01:23, cbentzel wrote:
> My previous change worked correctly, but this was a suggested improvement
which
> does not change the storage of the non-HTML forms in the sqlite db.

LGTM

It might be nice to merge the password_form_manager.cc part of this to stable
and beta.

[cbentzel, 2010-09-21 20:45:37]

I will merge with beta, not sure about stable.

On Tue, Sep 21, 2010 at 4:06 PM, <mdm@chromium.org> wrote:

> On 2010/09/21 19:01:23, cbentzel wrote:
>
>> My previous change worked correctly, but this was a suggested improvement
>>
> which
>
>> does not change the storage of the non-HTML forms in the sqlite db.
>>
>
> LGTM
>
> It might be nice to merge the password_form_manager.cc part of this to
> stable
> and beta.
>
>
> http://codereview.chromium.org/3419011/show
>

[cbentzel, 2010-09-21 20:49:09]

I added a unittest in the most recent patchset as well (strictly for
HasValidPasswordForm, I hope to add ui_tests for saved passwords in the next few
weeks).


On 2010/09/21 20:45:37, cbentzel wrote:
> I will merge with beta, not sure about stable.
> 
> On Tue, Sep 21, 2010 at 4:06 PM, <mailto:mdm@chromium.org> wrote:
> 
> > On 2010/09/21 19:01:23, cbentzel wrote:
> >
> >> My previous change worked correctly, but this was a suggested improvement
> >>
> > which
> >
> >> does not change the storage of the non-HTML forms in the sqlite db.
> >>
> >
> > LGTM
> >
> > It might be nice to merge the password_form_manager.cc part of this to
> > stable
> > and beta.
> >
> >
> > http://codereview.chromium.org/3419011/show
> >
>

[Mike Mammarella, 2010-09-21 20:57:33]

On 2010/09/21 20:49:09, cbentzel wrote:
> I added a unittest in the most recent patchset as well (strictly for
> HasValidPasswordForm, I hope to add ui_tests for saved passwords in the next
few
> weeks).

Yay moar tests!