Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: chrome/browser/password_manager/password_form_manager.cc

Issue 3419011: Save passwords for HTTP+FTP authentication.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/login_prompt.cc ('k') | chrome/browser/password_manager/password_form_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/password_form_manager.cc
===================================================================
--- chrome/browser/password_manager/password_form_manager.cc (revision 60051)
+++ chrome/browser/password_manager/password_form_manager.cc (working copy)
@@ -142,6 +142,10 @@
bool PasswordFormManager::HasValidPasswordForm() {
DCHECK_EQ(state_, POST_MATCHING_PHASE);
+ // Non-HTML password forms (primarily HTTP and FTP autentication)
+ // do not contain username_element and password_element values.
+ if (observed_form_.scheme != PasswordForm::SCHEME_HTML)
+ return true;
return !observed_form_.username_element.empty() &&
!observed_form_.password_element.empty();
}
« no previous file with comments | « chrome/browser/login_prompt.cc ('k') | chrome/browser/password_manager/password_form_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698