Makes match preview send the dimensions of the omnibox to the page.

Makes match preview send the dimensions of the omnibox to the page.

BUG=54833
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60153

[sky, 2010-09-21 20:46:36]

Peter, could you review the autocomplete side of things and Jay the rest?

Thanks,

  -Scott

[Peter Kasting, 2010-09-21 20:58:24]

What about when the window moves or is resized, do you need to do something
then?

LGTM otherwise

http://codereview.chromium.org/3417011/diff/5001/6003
File chrome/browser/autocomplete/autocomplete_popup_model.cc (right):

http://codereview.chromium.org/3417011/diff/5001/6003#newcode298
chrome/browser/autocomplete/autocomplete_popup_model.cc:298: #endif
Nit: Perhaps "#else" before TODO?

http://codereview.chromium.org/3417011/diff/5001/6004
File chrome/browser/autocomplete/autocomplete_popup_view.h (right):

http://codereview.chromium.org/3417011/diff/5001/6004#newcode35
chrome/browser/autocomplete/autocomplete_popup_view.h:35: // coordinates. This
returns the bounds the omnibox will resize to from the
Nit: Clarity: "...This returns the popup's current bounds when not animating, or
the desired target bounds when animating."?

http://codereview.chromium.org/3417011/diff/5001/6007
File chrome/browser/browser_window.h (right):

http://codereview.chromium.org/3417011/diff/5001/6007#newcode321
chrome/browser/browser_window.h:321: // Returns the bounds match preview will be
shown at.
Nit: This comment is somewhat confusing.  Is it something like:

// Returns the desired bounds for any match preview, in ___ coordinates.  Note
that a match preview does not need to actually be showing.

http://codereview.chromium.org/3417011/diff/5001/6019
File chrome/browser/views/frame/contents_container.cc (right):

http://codereview.chromium.org/3417011/diff/5001/6019#newcode116
chrome/browser/views/frame/contents_container.cc:116: return
gfx::Rect(screen_loc, gfx::Size(width(), height()));
Nit: Could use bounds_.size()?

[sky, 2010-09-21 21:19:06]

> What about when the window moves or is resized, do you need
> to do something then?

That closes the omnibox which then closes match preview, so it's covered.

All other nits addressed.

  -Scott

http://codereview.chromium.org/3417011/diff/5001/6019
File chrome/browser/views/frame/contents_container.cc (right):

http://codereview.chromium.org/3417011/diff/5001/6019#newcode116
chrome/browser/views/frame/contents_container.cc:116: return
gfx::Rect(screen_loc, gfx::Size(width(), height()));
On 2010/09/21 20:58:24, Peter Kasting wrote:
> Nit: Could use bounds_.size()?

Actually, I can just use size() here.

[Jay Civelli, 2010-09-22 01:18:54]

LGTM