Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Side by Side Diff: chrome/browser/cocoa/browser_window_cocoa.mm

Issue 3417011: Makes match preview send the dimensions of the omnibox to the page. (Closed)
Patch Set: Fix unittest Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/cocoa/browser_window_cocoa.h ('k') | chrome/browser/gtk/browser_window_gtk.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/cocoa/browser_window_cocoa.h" 5 #include "chrome/browser/cocoa/browser_window_cocoa.h"
6 6
7 #include "app/l10n_util_mac.h" 7 #include "app/l10n_util_mac.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/message_loop.h" 10 #include "base/message_loop.h"
(...skipping 556 matching lines...) Expand 10 before | Expand all | Expand 10 after
567 void BrowserWindowCocoa::ShowMatchPreview() { 567 void BrowserWindowCocoa::ShowMatchPreview() {
568 // TODO: implement me 568 // TODO: implement me
569 NOTIMPLEMENTED(); 569 NOTIMPLEMENTED();
570 } 570 }
571 571
572 void BrowserWindowCocoa::HideMatchPreview() { 572 void BrowserWindowCocoa::HideMatchPreview() {
573 // TODO: implement me 573 // TODO: implement me
574 NOTIMPLEMENTED(); 574 NOTIMPLEMENTED();
575 } 575 }
576 576
577 gfx::Rect BrowserWindowCocoa::GetMatchPreviewBounds() {
578 // TODO: implement me
579 NOTIMPLEMENTED();
580 return gfx::Rect();
581 }
582
577 void BrowserWindowCocoa::Observe(NotificationType type, 583 void BrowserWindowCocoa::Observe(NotificationType type,
578 const NotificationSource& source, 584 const NotificationSource& source,
579 const NotificationDetails& details) { 585 const NotificationDetails& details) {
580 switch (type.value) { 586 switch (type.value) {
581 // Only the key window gets a direct toggle from the menu. 587 // Only the key window gets a direct toggle from the menu.
582 // Other windows hear about it from the notification. 588 // Other windows hear about it from the notification.
583 case NotificationType::BOOKMARK_BAR_VISIBILITY_PREF_CHANGED: 589 case NotificationType::BOOKMARK_BAR_VISIBILITY_PREF_CHANGED:
584 [controller_ updateBookmarkBarVisibilityWithAnimation:YES]; 590 [controller_ updateBookmarkBarVisibilityWithAnimation:YES];
585 break; 591 break;
586 case NotificationType::SIDEBAR_CHANGED: 592 case NotificationType::SIDEBAR_CHANGED:
(...skipping 15 matching lines...) Expand all
602 608
603 NSWindow* BrowserWindowCocoa::window() const { 609 NSWindow* BrowserWindowCocoa::window() const {
604 return [controller_ window]; 610 return [controller_ window];
605 } 611 }
606 612
607 void BrowserWindowCocoa::UpdateSidebarForContents(TabContents* tab_contents) { 613 void BrowserWindowCocoa::UpdateSidebarForContents(TabContents* tab_contents) {
608 if (tab_contents == browser_->tabstrip_model()->GetSelectedTabContents()) { 614 if (tab_contents == browser_->tabstrip_model()->GetSelectedTabContents()) {
609 [controller_ updateSidebarForContents:tab_contents]; 615 [controller_ updateSidebarForContents:tab_contents];
610 } 616 }
611 } 617 }
OLDNEW
« no previous file with comments | « chrome/browser/cocoa/browser_window_cocoa.h ('k') | chrome/browser/gtk/browser_window_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698