Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 3416022: Revert 60357 - Merge 60334 - Add a launchApp method to extension management A... (Closed)

Created:
10 years, 3 months ago by asargent_no_longer_on_chrome
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 60357 - Merge 60334 - Add a launchApp method to extension management API. This makes it possible for new tab replacement extensions to recreate the same app launch experience as the built-in NTP (pinned tabs, launch containers, etc.) Also add the extension version to data we report about extensions via the management API. BUG=56325, 55474 TEST=An extension using chrome.experimental.management.launchApp(<id>) should work to launch an app the same way that app gets launched from the built-in new tab page. Review URL: http://codereview.chromium.org/3381019 TBR=asargent@chromium.org Review URL: http://codereview.chromium.org/3402027 TBR=asargent@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60375

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -364 lines) Patch
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_management_api.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_management_api.cc View 3 chunks +1 line, -24 lines 0 comments Download
M chrome/browser/extensions/extension_management_api_browsertest.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/common/extensions/api/extension_api.json View 2 chunks +0 lines, -21 lines 0 comments Download
M chrome/common/extensions/docs/experimental.management.html View 3 chunks +0 lines, -240 lines 0 comments Download
D chrome/test/data/extensions/management/launch_app/background.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/management/launch_app/manifest.json View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/test/data/extensions/management/launch_app/test.js View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/test/data/extensions/management/packaged_app/main.html View 1 chunk +0 lines, -8 lines 0 comments Download
D chrome/test/data/extensions/management/packaged_app/manifest.json View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/test/data/extensions/management/simple_extension/manifest.json View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
asargent_no_longer_on_chrome
10 years, 3 months ago (2010-09-23 23:12:52 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698