Issue 3415026: Makes instant support other open dispositions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3415026: Makes instant support other open dispositions. (Closed)

Created:
10 years, 2 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Jay Civelli

CC:
chromium-reviews, brettw-cc_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Makes instant support other open dispositions. BUG=54833 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60692

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -47 lines)			Patch
M	chrome/browser/browser.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/browser.cc	View	1 2	2 chunks	+29 lines, -5 lines	0 comments	Download
M	chrome/browser/tab_contents/match_preview.h	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/match_preview.cc	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/navigation_controller.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/tab_contents/navigation_controller.cc	View		2 chunks	+37 lines, -37 lines	0 comments	Download

Total messages: 4 (0 generated)

sky

I had to do a tweak based on merging and needed to move a method ...

10 years, 2 months ago (2010-09-27 16:33:37 UTC) #3

LGTM