Makes instant support other open dispositions.

chrome/browser/browser.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser.h"
 
 #if defined(OS_WIN)
 #include <shellapi.h>
 #include <windows.h>
 #endif  // OS_WIN
@@ skipping 1220 matching lines @@
 void Browser::Home(WindowOpenDisposition disposition) {
   UserMetrics::RecordAction(UserMetricsAction("Home"), profile_);
   OpenURL(GetHomePage(), GURL(), disposition, PageTransition::AUTO_BOOKMARK);
 }
 
 void Browser::OpenCurrentURL() {
   UserMetrics::RecordAction(UserMetricsAction("LoadURL"), profile_);
   LocationBar* location_bar = window_->GetLocationBar();
   WindowOpenDisposition open_disposition =
       location_bar->GetWindowOpenDisposition();
-  // TODO(sky): support other dispositions.
-  if (open_disposition == CURRENT_TAB && match_preview() &&
-      match_preview()->is_active()) {
-    match_preview()->CommitCurrentPreview(MatchPreview::COMMIT_PRESSED_ENTER);
+  if (OpenMatchPreview(open_disposition))
     return;
-  }
 
   GURL url(WideToUTF8(location_bar->GetInputString()));
 
   // Use ADD_INHERIT_OPENER so that all pages opened by the omnibox at least
   // inherit the opener. In some cases the tabstrip will determine the group
   // should be inherited, in which case the group is inherited instead of the
   // opener.
   OpenURLAtIndex(NULL, url, GURL(), open_disposition,
                  location_bar->GetPageTransition(), -1,
                  TabStripModel::ADD_FORCE_INDEX |
@@ skipping 2842 matching lines @@
 }
 
 void Browser::TabRestoreServiceDestroyed(TabRestoreService* service) {
   if (!tab_restore_service_)
     return;
 
   DCHECK_EQ(tab_restore_service_, service);
   tab_restore_service_->RemoveObserver(this);
   tab_restore_service_ = NULL;
 }
+
+bool Browser::OpenMatchPreview(WindowOpenDisposition disposition) {
+  if (!match_preview() || !match_preview()->is_active())
+    return false;
+
+  if (disposition == CURRENT_TAB) {
+    match_preview()->CommitCurrentPreview(MatchPreview::COMMIT_PRESSED_ENTER);
+    return true;
+  }
+  if (disposition == NEW_FOREGROUND_TAB || disposition == NEW_BACKGROUND_TAB) {
+    HideMatchPreview();
+    TabContents* preview_contents = match_preview()->ReleasePreviewContents(
+        MatchPreview::COMMIT_PRESSED_ENTER);
+    preview_contents->controller().PruneAllButActive();
+    tabstrip_model_->AddTabContents(
+        preview_contents,
+        -1,
+        match_preview()->last_transition_type(),
+        disposition == NEW_FOREGROUND_TAB ? TabStripModel::ADD_SELECTED :
+                                            TabStripModel::ADD_NONE);
+    return true;
+  }
+  // The omnibox currently doesn't use other dispositions, so we don't attempt
+  // to handle them. If you hit this NOTREACHED file a bug and I'll (sky) add
+  // support for the new disposition.
+  NOTREACHED();
+  return false;
+}