Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: crash_collector.cc

Issue 3414006: crash-reporter: Increase number of enqueued crash files, sending rate, and fix minor bug. (Closed) Base URL: http://git.chromium.org/git/crash-reporter.git
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | crash_sender » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: crash_collector.cc
diff --git a/crash_collector.cc b/crash_collector.cc
index 0194fc41ceefed66d5dd7f1b78f9b8b651ac4a49..f2f514694180b750240f4ea197b1673b99e66d48 100644
--- a/crash_collector.cc
+++ b/crash_collector.cc
@@ -26,8 +26,15 @@ static const mode_t kSystemCrashPathMode = 01755;
static const uid_t kRootOwner = 0;
static const uid_t kRootGroup = 0;
-// Maximum of 8 crash reports per directory.
-const int CrashCollector::kMaxCrashDirectorySize = 8;
+// Maximum crash reports per crash spool directory. Note that this is
+// a separate maximum from the maximum rate at which we upload these
+// diagnostics. The higher this rate is, the more space we allow for
+// core files, minidumps, and kcrash logs, and equivalently the more
+// processor and I/O bandwidth we dedicate to handling these crashes when
+// many occur at once. Also note that if core files are configured to
+// be left on the file system, we stop adding crashes when either the
+// number of core files or minidumps reaches this number.
+const int CrashCollector::kMaxCrashDirectorySize = 32;
CrashCollector::CrashCollector() : forced_crash_directory_(NULL) {
}
« no previous file with comments | « no previous file | crash_sender » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698