crash-reporter: Increase number of enqueued crash files, sending rate, and fix minor bug.

crash_collector.cc

 // Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "crash-reporter/crash_collector.h"
 
 #include <dirent.h>
 #include <pwd.h>  // For struct passwd.
 #include <sys/types.h>  // for mode_t.
 
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "crash-reporter/system_logging.h"
 
 static const char kDefaultUserName[] = "chronos";
 static const char kSystemCrashPath[] = "/var/spool/crash";
 static const char kUserCrashPath[] = "/home/chronos/user/crash";
 
 // Directory mode of the user crash spool directory.
 static const mode_t kUserCrashPathMode = 0755;
 
 // Directory mode of the system crash spool directory.
 static const mode_t kSystemCrashPathMode = 01755;
 
 static const uid_t kRootOwner = 0;
 static const uid_t kRootGroup = 0;
 
-// Maximum of 8 crash reports per directory.
-const int CrashCollector::kMaxCrashDirectorySize = 8;
+// Maximum crash reports per crash spool directory.  Note that this is
+// a separate maximum from the maximum rate at which we upload these
+// diagnostics.  The higher this rate is, the more space we allow for
+// core files, minidumps, and kcrash logs, and equivalently the more
+// processor and I/O bandwidth we dedicate to handling these crashes when
+// many occur at once.  Also note that if core files are configured to
+// be left on the file system, we stop adding crashes when either the
+// number of core files or minidumps reaches this number.
+const int CrashCollector::kMaxCrashDirectorySize = 32;
 
 CrashCollector::CrashCollector() : forced_crash_directory_(NULL) {
 }
 
 CrashCollector::~CrashCollector() {
 }
 
 void CrashCollector::Initialize(
     CrashCollector::CountCrashFunction count_crash_function,
     CrashCollector::IsFeedbackAllowedFunction is_feedback_allowed_function,
@@ skipping 145 matching lines @@
           "Crash directory %s already full with %d pending reports",
           crash_directory.value().c_str(),
           kMaxCrashDirectorySize);
       full = true;
       break;
     }
   }
   closedir(dir);
   return !full;
 }