Basis for cryptohome+power_SuspendResume stress test.

Basis for cryptohome+power_SuspendResume stress test.

BUG=chromeos:2172
TEST=Manually ran on my L13.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=50618ca

[ggg, 2010-12-01 16:57:02]

Sean,
It seems wrong to have multiple versions of the same tarball in the same source
tree.

Can we move
    client/deps/fio/fio-1.44.tar.bz2
to
    client/tests/fio/

or delete?
    client/tests/fio/fio-1.16.5.tar.bz2


I believe I can remove
    client/site_tests/hardware_StorageFio/fio-1.36.tar.bz2

once 1.44 tarball is parked some place reasonable.

[Kenneth Waters, 2011-01-07 17:46:53]

Seems to me would should have one copy of fio in client/deps/fio that's built
during the autotest-deps ebuild.

[ggg, 2011-01-11 01:16:04]

On 2011/01/07 17:46:53, Kenneth Waters wrote:
> Seems to me would should have one copy of fio in client/deps/fio that's built
> during the autotest-deps ebuild.

Ok. I'll investigate removing the others once this is committed.

Sean, when can you commit this change?

BTW, cmasone showed me how to fix platform_CryptohomeSyncStress.py so the test
can authenticate/login and need only one argument (which is what autotest
infrastructure expects) to run_once(). Please apply the diff below.

commit 2ec326cde109e9eb95669ccb1738fc528ff51298
Author: Grant Grundler <grundler@chromium.org>
Date:   Mon Jan 10 09:49:52 2011 -0800

    Use cros_ui_test to provide authentication since one cannot
    pass additional arguments in via "run_once()". Thanks to Chris Masone
    for showing me how to fix this.
    
    Change-Id: I123005cbceea259d2860454a7015bd41fc07db85

diff --git
a/client/site_tests/platform_CryptohomeSyncStress/platform_CryptohomeSyncStress.py
b/client/site_tests/platform_CryptohomeSyncStress/platform_CryptohomeSyncStress.py
index 57e69d1..602420b 100644
---
a/client/site_tests/platform_CryptohomeSyncStress/platform_CryptohomeSyncStress.py
+++
b/client/site_tests/platform_CryptohomeSyncStress/platform_CryptohomeSyncStress.py
@@ -5,15 +5,33 @@
 import dbus, string
 from autotest_lib.client.bin import test
 from autotest_lib.client.common_lib import error
-from autotest_lib.client.cros import login
+from autotest_lib.client.cros import cros_ui_test, login
 
-class platform_CryptohomeSyncStress(test.test):
-    version = 1
+class platform_CryptohomeSyncStress(cros_ui_test.UITest):
+    version = 2
 
-    def run_once(self, username, password):
+
+    def initialize(self, creds = '$default'):
+        cros_ui_test.UITest.initialize(self, creds)
+
+
+    def start_authserver(self):
+        pass
+

[seano, 2011-01-22 00:26:47]

ggg, Reviving this ancient CL.

That patch looks incomplete, is that the whole thing?

On 2011/01/11 01:16:04, ggg wrote:
> On 2011/01/07 17:46:53, Kenneth Waters wrote:
> > Seems to me would should have one copy of fio in client/deps/fio that's
built
> > during the autotest-deps ebuild.
> 
> Ok. I'll investigate removing the others once this is committed.
> 
> Sean, when can you commit this change?
> 
> BTW, cmasone showed me how to fix platform_CryptohomeSyncStress.py so the test
> can authenticate/login and need only one argument (which is what autotest
> infrastructure expects) to run_once(). Please apply the diff below.
> 
> commit 2ec326cde109e9eb95669ccb1738fc528ff51298
> Author: Grant Grundler <mailto:grundler@chromium.org>
> Date:   Mon Jan 10 09:49:52 2011 -0800
> 
>     Use cros_ui_test to provide authentication since one cannot
>     pass additional arguments in via "run_once()". Thanks to Chris Masone
>     for showing me how to fix this.
>     
>     Change-Id: I123005cbceea259d2860454a7015bd41fc07db85
> 
> diff --git
>
a/client/site_tests/platform_CryptohomeSyncStress/platform_CryptohomeSyncStress.py
>
b/client/site_tests/platform_CryptohomeSyncStress/platform_CryptohomeSyncStress.py
> index 57e69d1..602420b 100644
> ---
>
a/client/site_tests/platform_CryptohomeSyncStress/platform_CryptohomeSyncStress.py
> +++
>
b/client/site_tests/platform_CryptohomeSyncStress/platform_CryptohomeSyncStress.py
> @@ -5,15 +5,33 @@
>  import dbus, string
>  from autotest_lib.client.bin import test
>  from autotest_lib.client.common_lib import error
> -from autotest_lib.client.cros import login
> +from autotest_lib.client.cros import cros_ui_test, login
>  
> -class platform_CryptohomeSyncStress(test.test):
> -    version = 1
> +class platform_CryptohomeSyncStress(cros_ui_test.UITest):
> +    version = 2
>  
> -    def run_once(self, username, password):
> +
> +    def initialize(self, creds = '$default'):
> +        cros_ui_test.UITest.initialize(self, creds)
> +
> +
> +    def start_authserver(self):
> +        pass
> +

[ggg, 2011-01-22 01:27:16]

On Fri, Jan 21, 2011 at 4:26 PM,  <seano@chromium.org> wrote:
> Reviewers: fes, ggg, Kenneth Waters,
>
> Message:
> ggg, Reviving this ancient CL.
>
> That patch looks incomplete, is that the whole thing?

Yes. I think so. We only modified the one file to run one test. Other
files might need the same treatment to run other tests that are being
added.

thanks,
grant

>
> On 2011/01/11 01:16:04, ggg wrote:
>>
>> On 2011/01/07 17:46:53, Kenneth Waters wrote:
>> > Seems to me would should have one copy of fio in client/deps/fio that's
>
> built
>>
>> > during the autotest-deps ebuild.
>
>> Ok. I'll investigate removing the others once this is committed.
>
>> Sean, when can you commit this change?
>
>> BTW, cmasone showed me how to fix platform_CryptohomeSyncStress.py so the
>> test
>> can authenticate/login and need only one argument (which is what autotest
>> infrastructure expects) to run_once(). Please apply the diff below.
>
>> commit 2ec326cde109e9eb95669ccb1738fc528ff51298
>> Author: Grant Grundler <mailto:grundler@chromium.org>
>> Date:   Mon Jan 10 09:49:52 2011 -0800
>
>>     Use cros_ui_test to provide authentication since one cannot
>>     pass additional arguments in via "run_once()". Thanks to Chris Masone
>>     for showing me how to fix this.
>
>>     Change-Id: I123005cbceea259d2860454a7015bd41fc07db85
>
>> diff --git
>
>
a/client/site_tests/platform_CryptohomeSyncStress/platform_CryptohomeSyncStress.py
>
>
b/client/site_tests/platform_CryptohomeSyncStress/platform_CryptohomeSyncStress.py
>>
>> index 57e69d1..602420b 100644
>> ---
>
>
a/client/site_tests/platform_CryptohomeSyncStress/platform_CryptohomeSyncStress.py
>>
>> +++
>
>
b/client/site_tests/platform_CryptohomeSyncStress/platform_CryptohomeSyncStress.py
>>
>> @@ -5,15 +5,33 @@
>>  import dbus, string
>>  from autotest_lib.client.bin import test
>>  from autotest_lib.client.common_lib import error
>> -from autotest_lib.client.cros import login
>> +from autotest_lib.client.cros import cros_ui_test, login
>
>> -class platform_CryptohomeSyncStress(test.test):
>> -    version = 1
>> +class platform_CryptohomeSyncStress(cros_ui_test.UITest):
>> +    version = 2
>
>> -    def run_once(self, username, password):
>> +
>> +    def initialize(self, creds = '$default'):
>> +        cros_ui_test.UITest.initialize(self, creds)
>> +
>> +
>> +    def start_authserver(self):
>> +        pass
>> +
>
>
>
> Description:
> Basis for cryptohome+power_SuspendResume stress test.
>
> BUG=
> TEST=Manually ran on my L13.
>
> Please review this at http://codereview.chromium.org/3412036/
>
> SVN Base: http://git.chromium.org/git/autotest.git
>
> Affected files:
>  M client/common_lib/rtc.py
>  M client/common_lib/sys_power.py
>  A client/deps/fio/Makefile.patch
>  A client/deps/fio/common.py
>  A client/deps/fio/control
>  A client/deps/fio/crc32c-intel.patch
>  A client/deps/fio/fio-1.44.tar.bz2
>  A client/deps/fio/fio.py
>  A client/site_tests/platform_CryptohomeFio/16k_read
>  A client/site_tests/platform_CryptohomeFio/16k_write
>  A client/site_tests/platform_CryptohomeFio/4k_read
>  A client/site_tests/platform_CryptohomeFio/4k_write
>  A client/site_tests/platform_CryptohomeFio/8k_read
>  A client/site_tests/platform_CryptohomeFio/8k_write
>  A client/site_tests/platform_CryptohomeFio/boot
>  A client/site_tests/platform_CryptohomeFio/control
>  A client/site_tests/platform_CryptohomeFio/control.new
>  A client/site_tests/platform_CryptohomeFio/login
>  A client/site_tests/platform_CryptohomeFio/platform_CryptohomeFio.py
>  A client/site_tests/platform_CryptohomeFio/quick_write
>  A client/site_tests/platform_CryptohomeFio/seq_read
>  A client/site_tests/platform_CryptohomeFio/seq_write
>  A client/site_tests/platform_CryptohomeFio/seq_write_verified
>  A client/site_tests/platform_CryptohomeFio/surfing
>  A client/site_tests/platform_CryptohomeStress/control
>  A client/site_tests/platform_CryptohomeStress/control.surfing
>  A client/site_tests/platform_CryptohomeStress/platform_CryptohomeStress.py
>  A client/site_tests/platform_SuspendStress/control
>  A client/site_tests/platform_SuspendStress/platform_SuspendStress.py
>
>
>

[seano, 2011-01-27 22:50:02]

ggg, the patch doesn't apply to any files in this changelist.

I'd like to submit it. It works today, and I will go through and cleanup /
eliminate common functionality between the two tests afterwards.

On 2011/01/22 01:27:16, ggg wrote:
> On Fri, Jan 21, 2011 at 4:26 PM,  <mailto:seano@chromium.org> wrote:
> > Reviewers: fes, ggg, Kenneth Waters,
> >
> > Message:
> > ggg, Reviving this ancient CL.
> >
> > That patch looks incomplete, is that the whole thing?
> 
> Yes. I think so. We only modified the one file to run one test. Other
> files might need the same treatment to run other tests that are being
> added.
> 
> thanks,
> grant
> 
> >
> > On 2011/01/11 01:16:04, ggg wrote:
> >>
> >> On 2011/01/07 17:46:53, Kenneth Waters wrote:
> >> > Seems to me would should have one copy of fio in client/deps/fio that's
> >
> > built
> >>
> >> > during the autotest-deps ebuild.
> >
> >> Ok. I'll investigate removing the others once this is committed.
> >
> >> Sean, when can you commit this change?
> >
> >> BTW, cmasone showed me how to fix platform_CryptohomeSyncStress.py so the
> >> test
> >> can authenticate/login and need only one argument (which is what autotest
> >> infrastructure expects) to run_once(). Please apply the diff below.
> >
> >> commit 2ec326cde109e9eb95669ccb1738fc528ff51298
> >> Author: Grant Grundler <mailto:grundler@chromium.org>
> >> Date: &nbsp; Mon Jan 10 09:49:52 2011 -0800
> >
> >> &nbsp; &nbsp; Use cros_ui_test to provide authentication since one cannot
> >> &nbsp; &nbsp; pass additional arguments in via "run_once()". Thanks to
Chris Masone
> >> &nbsp; &nbsp; for showing me how to fix this.
> >
> >> &nbsp; &nbsp; Change-Id: I123005cbceea259d2860454a7015bd41fc07db85
> >
> >> diff --git
> >
> >
>
a/client/site_tests/platform_CryptohomeSyncStress/platform_CryptohomeSyncStress.py
> >
> >
>
b/client/site_tests/platform_CryptohomeSyncStress/platform_CryptohomeSyncStress.py
> >>
> >> index 57e69d1..602420b 100644
> >> ---
> >
> >
>
a/client/site_tests/platform_CryptohomeSyncStress/platform_CryptohomeSyncStress.py
> >>
> >> +++
> >
> >
>
b/client/site_tests/platform_CryptohomeSyncStress/platform_CryptohomeSyncStress.py
> >>
> >> @@ -5,15 +5,33 @@
> >> &nbsp;import dbus, string
> >> &nbsp;from autotest_lib.client.bin import test
> >> &nbsp;from autotest_lib.client.common_lib import error
> >> -from autotest_lib.client.cros import login
> >> +from autotest_lib.client.cros import cros_ui_test, login
> >
> >> -class platform_CryptohomeSyncStress(test.test):
> >> - &nbsp; &nbsp;version = 1
> >> +class platform_CryptohomeSyncStress(cros_ui_test.UITest):
> >> + &nbsp; &nbsp;version = 2
> >
> >> - &nbsp; &nbsp;def run_once(self, username, password):
> >> +
> >> + &nbsp; &nbsp;def initialize(self, creds = '$default'):
> >> + &nbsp; &nbsp; &nbsp; &nbsp;cros_ui_test.UITest.initialize(self, creds)
> >> +
> >> +
> >> + &nbsp; &nbsp;def start_authserver(self):
> >> + &nbsp; &nbsp; &nbsp; &nbsp;pass
> >> +
> >
> >
> >
> > Description:
> > Basis for cryptohome+power_SuspendResume stress test.
> >
> > BUG=
> > TEST=Manually ran on my L13.
> >
> > Please review this at http://codereview.chromium.org/3412036/
> >
> > SVN Base: http://git.chromium.org/git/autotest.git
> >
> > Affected files:
> > &nbsp;M client/common_lib/rtc.py
> > &nbsp;M client/common_lib/sys_power.py
> > &nbsp;A client/deps/fio/Makefile.patch
> > &nbsp;A client/deps/fio/common.py
> > &nbsp;A client/deps/fio/control
> > &nbsp;A client/deps/fio/crc32c-intel.patch
> > &nbsp;A client/deps/fio/fio-1.44.tar.bz2
> > &nbsp;A client/deps/fio/fio.py
> > &nbsp;A client/site_tests/platform_CryptohomeFio/16k_read
> > &nbsp;A client/site_tests/platform_CryptohomeFio/16k_write
> > &nbsp;A client/site_tests/platform_CryptohomeFio/4k_read
> > &nbsp;A client/site_tests/platform_CryptohomeFio/4k_write
> > &nbsp;A client/site_tests/platform_CryptohomeFio/8k_read
> > &nbsp;A client/site_tests/platform_CryptohomeFio/8k_write
> > &nbsp;A client/site_tests/platform_CryptohomeFio/boot
> > &nbsp;A client/site_tests/platform_CryptohomeFio/control
> > &nbsp;A client/site_tests/platform_CryptohomeFio/control.new
> > &nbsp;A client/site_tests/platform_CryptohomeFio/login
> > &nbsp;A client/site_tests/platform_CryptohomeFio/platform_CryptohomeFio.py
> > &nbsp;A client/site_tests/platform_CryptohomeFio/quick_write
> > &nbsp;A client/site_tests/platform_CryptohomeFio/seq_read
> > &nbsp;A client/site_tests/platform_CryptohomeFio/seq_write
> > &nbsp;A client/site_tests/platform_CryptohomeFio/seq_write_verified
> > &nbsp;A client/site_tests/platform_CryptohomeFio/surfing
> > &nbsp;A client/site_tests/platform_CryptohomeStress/control
> > &nbsp;A client/site_tests/platform_CryptohomeStress/control.surfing
> > &nbsp;A
client/site_tests/platform_CryptohomeStress/platform_CryptohomeStress.py
> > &nbsp;A client/site_tests/platform_SuspendStress/control
> > &nbsp;A client/site_tests/platform_SuspendStress/platform_SuspendStress.py
> >
> >
> >

[ggg, 2011-01-27 23:45:02]

LGTM

On 2011/01/27 22:50:02, seano wrote:
> ggg, the patch doesn't apply to any files in this changelist.

Sorry! I confused "platform_CryptohomeStress.py" with
"platform_CryptohomeSyncStress.py" (file I modified).

I'll submit the patch separately.

> I'd like to submit it. It works today, and I will go through and cleanup /
> eliminate common functionality between the two tests afterwards.

No problem - I agree with getting it in the tree will enable other work on it.

thanks,
grant

[DaleCurtis, 2011-01-31 23:10:03]

Autotest fails under USE=buildcheck without these fixes.

Also why two control files in platform_CryptohomeFio?

http://codereview.chromium.org/3412036/diff/24002/client/site_tests/platform_...
File client/site_tests/platform_CryptohomeFio/platform_CryptohomeFio.py (right):

http://codereview.chromium.org/3412036/diff/24002/client/site_tests/platform_...
client/site_tests/platform_CryptohomeFio/platform_CryptohomeFio.py:6: from
autotest_lib.client.bin import chromeos_constants, site_cryptohome
These paths are wrong, should be:

from autotest_lib.client.cros import cryptohome as site_cryptohome
from autotest_lib.client.cros import constants as chromeos_constants