Issue 3412028: Support dec_b instruction in ia32 and x64 disassembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3412028: Support dec_b instruction in ia32 and x64 disassembler. (Closed)

Created:
10 years, 3 months ago by Vladislav Kaznacheev

Modified:
9 years, 7 months ago

Reviewers:
antonm, Vitaly Repeshko

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Support dec_b instruction in ia32 and x64 disassembler. Committed: http://code.google.com/p/v8/source/detail?r=5515

Patch Set 2 : '' #

Total comments: 2

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
M	src/ia32/disasm-ia32.cc	View	1	1 chunk	+3 lines, -3 lines	2 comments	Download
M	src/x64/disasm-x64.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	test/cctest/test-disasm-ia32.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

The disassembler test works, and the output contains decb/dec_b instructions. On 2010/09/23 18:29:41, Vitaly wrote: ...

10 years, 3 months ago (2010-09-23 19:01:45 UTC) #4

antonm

http://codereview.chromium.org/3412028/diff/5001/6001 File src/ia32/disasm-ia32.cc (right): http://codereview.chromium.org/3412028/diff/5001/6001#newcode1199 src/ia32/disasm-ia32.cc:1199: data += PrintRightOperand(data); shouldn't that be PrintRightByteOperand?

10 years, 3 months ago (2010-09-23 19:23:09 UTC) #5