Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 341073: Put back some scons files that the docs build parses.... (Closed)

Created:
11 years, 1 month ago by Greg Spencer
Modified:
9 years, 7 months ago
Reviewers:
petersont, gman, bradn
CC:
o3d-review_googlegroups.com
Visibility:
Public.

Description

Put back some scons files that the docs build parses, but rename them with ".manifest", since we no longer have a scons build. We should probably change the code that parses these to be simpler someday. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -0 lines) Patch
A plugin/idl_list.scons View 1 chunk +92 lines, -0 lines 0 comments Download
A samples/o3djs/js_list.scons View 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Greg Spencer
11 years, 1 month ago (2009-11-02 23:41:29 UTC) #1
petersont
LGTM.
11 years, 1 month ago (2009-11-02 23:43:49 UTC) #2
bradn
LGTM
11 years, 1 month ago (2009-11-02 23:44:12 UTC) #3
gman
11 years, 1 month ago (2009-11-03 02:51:23 UTC) #4
On 2009/11/02 23:44:12, bradn wrote:
> LGTM

If these files are not used directly by the GYP build then either the docs code
needs to change or gyp needs to change so that one way or another there is only
one list of these files. Otherwise, people will update one list and not the
other and docs will be missing or not run through the jscompiler, etc..

Powered by Google App Engine
This is Rietveld 408576698