Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 341057: DevTools: add all scripts from afterCompile events when scripts panel is show... (Closed)

Created:
11 years, 1 month ago by yurys
Modified:
9 years, 7 months ago
Reviewers:
apavlov, pfeldman
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Visibility:
Public.

Description

DevTools: add all scripts from afterCompile events when scripts panel is shown for the first time BUG=26312 TEST=DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30664

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -7 lines) Patch
M chrome/browser/debugger/devtools_sanity_unittest.cc View 3 chunks +19 lines, -2 lines 0 comments Download
M webkit/glue/devtools/js/debugger_agent.js View 1 2 3 chunks +13 lines, -5 lines 0 comments Download
M webkit/glue/devtools/js/tests.js View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
11 years, 1 month ago (2009-10-30 20:17:18 UTC) #1
pfeldman
LGTM. Any chance we can get a test for this?
11 years, 1 month ago (2009-10-30 21:20:00 UTC) #2
yurys
11 years, 1 month ago (2009-10-31 08:38:25 UTC) #3
Added a test.

On 2009/10/30 21:20:00, pfeldman wrote:
> LGTM. Any chance we can get a test for this?

Powered by Google App Engine
This is Rietveld 408576698