Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Unified Diff: chrome/browser/debugger/devtools_sanity_unittest.cc

Issue 341057: DevTools: add all scripts from afterCompile events when scripts panel is show... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/glue/devtools/js/debugger_agent.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/debugger/devtools_sanity_unittest.cc
===================================================================
--- chrome/browser/debugger/devtools_sanity_unittest.cc (revision 30578)
+++ chrome/browser/debugger/devtools_sanity_unittest.cc (working copy)
@@ -108,8 +108,7 @@
GURL url = server->TestServerPageW(test_page);
ui_test_utils::NavigateToURL(browser(), url);
- TabContents* tab = browser()->GetTabContentsAt(0);
- inspected_rvh_ = tab->render_view_host();
+ inspected_rvh_ = GetInspectedTab()->render_view_host();
DevToolsManager* devtools_manager = DevToolsManager::GetInstance();
devtools_manager->OpenDevToolsWindow(inspected_rvh_);
@@ -121,6 +120,10 @@
ui_test_utils::WaitForNavigation(&client_contents_->controller());
}
+ TabContents* GetInspectedTab() {
+ return browser()->GetTabContentsAt(0);
+ }
+
void CloseDevToolsWindow() {
DevToolsManager* devtools_manager = DevToolsManager::GetInstance();
// UnregisterDevToolsClientHostFor may destroy window_ so store the browser
@@ -282,6 +285,20 @@
RunTest("testShowScriptsTab", kDebuggerTestPage);
}
+// Tests that scripts tab is populated with inspected scripts even if it
+// hadn't been shown by the moment inspected paged refreshed.
+// @see http://crbug.com/26312
+IN_PROC_BROWSER_TEST_F(DevToolsSanityTest,
+ TestScriptsTabIsPopulatedOnInspectedPageRefresh) {
+ // Reset inspector settings to defaults to ensure that Elements will be
+ // current panel when DevTools window is open.
+ GetInspectedTab()->render_view_host()->delegate()->UpdateInspectorSettings(
+ WebPreferences().inspector_settings);
+ RunTest("testScriptsTabIsPopulatedOnInspectedPageRefresh",
+ kDebuggerTestPage);
+}
+
+
// Tests that a content script is in the scripts list.
IN_PROC_BROWSER_TEST_F(DevToolsExtensionDebugTest,
TestContentScriptIsPresent) {
« no previous file with comments | « no previous file | webkit/glue/devtools/js/debugger_agent.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698