Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 341025: Change the extension.onRequest even to include the sender info. (Closed)

Created:
11 years, 1 month ago by Matt Perry
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Change the extension.onRequest even to include the sender info. BUG=23865 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30534

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix args #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -39 lines) Patch
M chrome/common/extensions/api/extension_api.json View 1 4 chunks +17 lines, -10 lines 0 comments Download
M chrome/common/extensions/docs/extension.html View 1 11 chunks +140 lines, -11 lines 0 comments Download
M chrome/renderer/resources/renderer_extension_bindings.js View 1 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/test/data/extensions/api_test/connect/page.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/connect/test.html View 1 1 chunk +15 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Matt Perry
11 years, 1 month ago (2009-10-28 21:24:45 UTC) #1
Aaron Boodman
http://codereview.chromium.org/341025/diff/1/6 File chrome/test/data/extensions/api_test/connect/test.html (right): http://codereview.chromium.org/341025/diff/1/6#newcode5 Line 5: chrome.extension.onRequest.addListener(function(info) { I realize this is all personal, ...
11 years, 1 month ago (2009-10-29 01:37:36 UTC) #2
Matt Perry
OK, went with 3 args as you suggested.
11 years, 1 month ago (2009-10-29 22:30:23 UTC) #3
Aaron Boodman
11 years, 1 month ago (2009-10-29 23:45:44 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698