Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: chrome/renderer/resources/renderer_extension_bindings.js

Issue 341025: Change the extension.onRequest even to include the sender info. (Closed)
Patch Set: fix args Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/docs/extension.html ('k') | chrome/test/data/extensions/api_test/connect/page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/renderer_extension_bindings.js
diff --git a/chrome/renderer/resources/renderer_extension_bindings.js b/chrome/renderer/resources/renderer_extension_bindings.js
index bf288bdf42daab6028d88a6a568bdb1a39695ca9..718c414f6f6d0271c81b005d6083b08102368a6d 100644
--- a/chrome/renderer/resources/renderer_extension_bindings.js
+++ b/chrome/renderer/resources/renderer_extension_bindings.js
@@ -73,6 +73,10 @@ var chrome = chrome || {};
// the right event.
var isExternal = sourceExtensionId != chromeHidden.extensionId;
+ if (tab)
+ tab = JSON.parse(tab);
+ var sender = {tab: tab, id: sourceExtensionId};
+
// Special case for sendRequest/onRequest.
if (channelName == chromeHidden.kRequestChannel) {
var requestEvent = (isExternal ?
@@ -80,7 +84,7 @@ var chrome = chrome || {};
if (requestEvent.hasListeners()) {
var port = chromeHidden.Port.createPort(portId, channelName);
port.onMessage.addListener(function(request) {
- requestEvent.dispatch(request, function(response) {
+ requestEvent.dispatch(request, sender, function(response) {
port.postMessage(response);
});
});
@@ -92,10 +96,7 @@ var chrome = chrome || {};
chrome.extension.onConnectExternal : chrome.extension.onConnect);
if (connectEvent.hasListeners()) {
var port = chromeHidden.Port.createPort(portId, channelName);
- if (tab) {
- tab = JSON.parse(tab);
- }
- port.sender = {tab: tab, id: sourceExtensionId};
+ port.sender = sender;
// TODO(EXTENSIONS_DEPRECATED): port.tab is obsolete.
port.tab = port.sender.tab;
« no previous file with comments | « chrome/common/extensions/docs/extension.html ('k') | chrome/test/data/extensions/api_test/connect/page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698