Issue 341016: GTK: touch up appearance of browser actions badge....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 341016: GTK: touch up appearance of browser actions badge.... (Closed)

Created:
11 years, 1 month ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Aaron Boodman, DaveMoore

CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org, Evan Stade

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

GTK: touch up appearance of browser actions badge. Also don't show empty browser action tooltips. BUG=26023 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30316

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -7 lines)			Patch
	M	chrome/browser/gtk/browser_actions_toolbar_gtk.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download
	M	chrome/common/extensions/extension_action.cc	View	1	4 chunks	+8 lines, -5 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

LGTM! +evan, wondering if he knows why the constants would need to be different. I ...

11 years, 1 month ago (2009-10-28 03:18:12 UTC) #3

Evan Stade

on linux skia uses pango for drawing text. Different backend, slightly different constants---shrug. Dave Moore ...

11 years, 1 month ago (2009-10-28 03:21:20 UTC) #4

DaveMoore

11 years, 1 month ago (2009-10-28 16:49:47 UTC) #5

There are definitely some pixel level differences between the way pango and
Windows vertically center text, but these differences could be because of the
different fonts. It's hard to say what the pad constants should be in general.

On 2009/10/28 03:21:20, Evan Stade wrote:
> on linux skia uses pango for drawing text. Different backend, slightly
different
> constants---shrug. Dave Moore has been looking closely at this recently.

Expand Messages | Collapse Messages