Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1962)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/gtk/browser_actions_toolbar_gtk.cc

Issue 341016: GTK: touch up appearance of browser actions badge.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/extension_action.cc » ('j') | chrome/common/extensions/extension_action.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/browser_actions_toolbar_gtk.cc
===================================================================
--- chrome/browser/gtk/browser_actions_toolbar_gtk.cc (revision 30311)
+++ chrome/browser/gtk/browser_actions_toolbar_gtk.cc (working copy)
@@ -115,8 +115,11 @@
if (tab_id < 0)
return;
- gtk_widget_set_tooltip_text(button_.get(),
- extension_->browser_action()->GetTitle(tab_id).c_str());
+ std::string tooltip = extension_->browser_action()->GetTitle(tab_id);
+ if (tooltip.empty())
+ gtk_widget_set_has_tooltip(button_.get(), FALSE);
+ else
+ gtk_widget_set_tooltip_text(button_.get(), tooltip.c_str());
SkBitmap image = extension_->browser_action()->GetIcon(tab_id);
if (!image.isNull()) {
« no previous file with comments | « no previous file | chrome/common/extensions/extension_action.cc » ('j') | chrome/common/extensions/extension_action.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698