Make sure drover works when depot_tools is not in the path.

Make sure drover works when depot_tools is not in the path.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30865

[chase, 2009-10-28 00:58:44]

http://codereview.chromium.org/341013/diff/1/2
File drover.py (right):

http://codereview.chromium.org/341013/diff/1/2#newcode38
Line 38: gcl_path = os.path.join(os.path.dirname(os.path.abspath(sys.argv[0])),
"gcl")
Re: devs that don't have depot_tools in their path, it would be good to follow
this with a test that gcl_path exists, and a helpful error if it doesn't.

http://codereview.chromium.org/341013/diff/1/2#newcode68
Line 68: os.system(command)
Though the value isn't tested anywhere, this should probably be 'return
os.system(command)'.

[M-A Ruel, 2009-10-28 01:11:52]

http://codereview.chromium.org/341013/diff/1/2
File drover.py (right):

http://codereview.chromium.org/341013/diff/1/2#newcode38
Line 38: gcl_path = os.path.join(os.path.dirname(os.path.abspath(sys.argv[0])),
"gcl")
you can probably use __file__ instead of sys.argv[0], that's what I usually do.
I heard sys.argv[0] may be sometimes wrong, not sure about __file__.

[Nicolas Sylvain, 2009-11-02 23:49:28]

updated with comments from both of you,

thanks

Nicolas


On Tue, Oct 27, 2009 at 6:11 PM, <maruel@chromium.org> wrote:

>
> http://codereview.chromium.org/341013/diff/1/2
> File drover.py (right):
>
> http://codereview.chromium.org/341013/diff/1/2#newcode38
> Line 38: gcl_path =
> os.path.join(os.path.dirname(os.path.abspath(sys.argv[0])), "gcl")
> you can probably use __file__ instead of sys.argv[0], that's what I
> usually do. I heard sys.argv[0] may be sometimes wrong, not sure about
> __file__.
>
>
> http://codereview.chromium.org/341013
>

[chase, 2009-11-03 21:10:45]

lgtm