Issue 3402026: Fix WebGL getParameter bug in command buffer. ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3402026: Fix WebGL getParameter bug in command buffer. ... (Closed)

Created:
10 years, 3 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix WebGL getParameter bug in command buffer. GetHelper was turning all getParameter return values into integers, even if they should have been floats. By returning false in GetHelper, it lets the individual DoGet(Float,Boolean,Integer)v functions skip this behavior and return the real value directly. BUG=51331 TEST=LayoutTests/fast/canvas/webgl/gl-get-calls.html R=apatrick,gman Patch by Adrienne Walker (enne@chromium.org) Originally reviewed at http://codereview.chromium.org/3023042 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60236

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download